External icon libraries & token generation #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kdonovan
approved these changes
Jul 31, 2023
| import fs from 'fs'; | ||
| import path from 'path'; | ||
| import prettier from 'prettier'; | ||
| import tokens from './../src/styles/tokens.json' assert { type: 'json' }; |
There was a problem hiding this comment.
Yeah, that's a new / experimental Node thing. You get a warning in the console, but it works.
src/styles/exports/overrides.css
Outdated
| @@ -580,12 +582,12 @@ sl-dialog.small::part(body) { | |||
| --header-spacing: 32px 0 16px 24px; | |||
| } | |||
|
|
|||
| sl-dialog.has-icon > div { | |||
| sl-dialog.has-icon>div { | |||
There was a problem hiding this comment.
The syntax highlighting implies the lack of spaces around > is fine, just calling it out to be sure :)
There was a problem hiding this comment.
I had initially added these files to .prettierignore, but trying out putting them back in
There was a problem hiding this comment.
I ended up being able to just ignore one of the CSS files (the generated one), which for whatever reason fails the prettier check on CI, but not locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update does two things:
Wraps up the external icon library registration into a single exported method that can be called as-is.This will allow the Rails app, the docs site, and CodePen to all just call
registerExternalLibraries()instead of duplicating the registration logic for each library like they do currently.Creates a single source-of-truth for color and font tokens in JSON and then generates all the CSS tokens via automation. In addition to cleaning things up, this will allow us to import that same JSON into shared-ui and use it to generate the tailwind config, and thus avoid having our color tokens defined in multiple places. The tokens are exported and available via CDN or through the package itself via Yarn/NPM.