change default icon size for small buttons #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CrookedGrin
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Hey, Anne! Thanks for making this PR. I'm happy to pull this in, but it's also possible to make the change directly within the button itself. We're planning to eventually migrate all these override styles into the actual CSS of the library. The overrides were initially necessary before we had our own fork of Shoelace that we could edit directly.
If you need this sooner rather than later, LMK and we can just pull this in now.
|
made the change! @CrookedGrin |
CrookedGrin
approved these changes
Mar 23, 2023
CrookedGrin
suggested changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.