Contained Radio & Checkbox #6
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <slot></slot> | ||
| <div class="checkbox__label-description-container"> | ||
| <slot part="label" class="checkbox__label"></slot> | ||
| <div class="checkbox__description-block"></div> |
There was a problem hiding this comment.
this is to put space between the label and description. it's not ideal, but this section has a line-height (in order for it to lineup with the checkbox/radio) which does not allow for a margin 😭
There was a problem hiding this comment.
Yeah, styling checkboxes has always been a PITA
There was a problem hiding this comment.
This looks great! I checked (ha ha) on the other usages of checkbox, such as in <sl-menu-item> and in forms, and it all looks good. The one missing thing is to bump the version (still showing 1.0.6, would maybe call this 1.1.0 since it changed the rendering of the checkbox) and add a changelog entry. Then once we merge we can cut another release.
https://www.figma.com/file/BrXOVNTglDWg03DL7ZZeW1/Teamshares-UI?t=ymYY1RK2fUGLGvQM-0
slack discussion on implementation: https://teamsharesinc.slack.com/archives/C04KR6HQ5L7/p1679584015946389