generated from Chemaclass/php-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEA-2009] Command Bus #60
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
============================================
- Coverage 46.42% 41.36% -5.06%
- Complexity 174 224 +50
============================================
Files 19 22 +3
Lines 545 689 +144
============================================
+ Hits 253 285 +32
- Misses 292 404 +112 ☔ View full report in Codecov by Sentry. |
…riable feat(index.php): add support for environment secrets in RabbitMQ configuration feat(index.php): add support for RabbitMQ singleton instance creation with environment secrets docs(AutoloadConfig.php): add parameter descriptions to the constructor
feat(Dockerfile): add xdebug extension and configure it refactor(SampleRepo/index.php): add check for action prefix in method name and add namespace exclusion to AutoloaderEventMapGenerator feat(SampleRepo): add SampleVideoPermissionChangeCommand to SampleRepo Add publisher.php file that publishes a SampleVideoPermissionChangeCommand to RabbitMQ using the CommandBus. Also, add SampleConsumerForCommands.php file that handles the SampleVideoPermissionChangeCommand and publishes a message to the queue specified in the command. Finally, add SampleController.php file that has a handleSampleCommand method that handles the SampleVideoPermissionChangeCommand. refactor(SampleVideoPermissionChangeCommand.php): change commandName method to eventName feat(SampleVideoPermissionChangeCommand.php): add support for queueToReply property feat(to_temp.php): add script to publish message to RabbitMQ queue chore(composer.json): add amphp/phpunit-util dependency chore(docker-compose.yml): add PHP_IDE_CONFIG environment variable feat(docker-compose.yml): add AMQP2FCGI_FCGI_XDEBUG and AMQP2FCGI_FCGI_FAKEIP environment variables refactor(Command.php): change method name from commandName to eventName refactor(EventMapGenerator.php): change return type to class-string<Event|Command> refactor(AsyncSendEventMiddleware.php): simplify execute method and add validation for Command instance feat(AutoloaderEventMapGenerator.php): add support for Command class in event map generator refactor(ConsumerConfigGenerator.php): change method call from commandName() to eventName() fix(Rabbit.php): add queueName parameter to queue_bind() method call feat(Rabbit.php): add wait() method to Rabbit class to wait for messages to arrive refactor(SimpleEventMapGenerator.php): add Command to the return type of get() method feat(SyncSendEventMiddleware.php): add SyncSendEventMiddleware class to handle synchronous event sending and receiving feat(GoAssistedConsumer.php): add Command type to the return of unserialize method test(CommandBusIntegrationTest.php): add test for command bus with async event middleware and RabbitMQ instance. test(AutoloaderEventMapGeneratorTest.php): add test for SampleVideoPermissionChangeCommand class to getAll() and generate_event_map_creates_file_with_correct_content() methods feat(AutoloaderEventMapGenerator.php): add support for SampleVideoPermissionChangeCommand class to getAll() method test(GoAssistedConsumerTest.php): add test for parsing SampleVideoPermissionChangeCommand request
…to SynchronousSendEventMiddleware feat(SynchronousSendEventMiddleware.php): add SynchronousSendEventMiddleware class to send events synchronously via RabbitMQ test(CommandBusIntegrationTest.php): rename test_command_bus to test_synchronous_command_bus and assert the result of the command execution
1085d8c
to
ec3b18c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Background
Command Bus implementation
💡 Goal
The goal of this PR.
🔖 Changes
List individual changes in more detail as you might consider them important.