Pyto tomoloading #22
Merged
Pyto tomoloading #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzLamm
commented
Jul 19, 2023
| data -= np.mean(data) | ||
| data /= np.std(data) | ||
| if return_header: | ||
| return data, header |
There was a problem hiding this comment.
Not sure what I was doing in the previous version :D
The new version is even shorter
LorenzLamm
commented
Jul 19, 2023
| if header is not None: | ||
| attributes = header.dtype.names | ||
| for attr in attributes: | ||
| setattr(out_mrc.header, attr, getattr(header, attr)) |
There was a problem hiding this comment.
the header could not be set directly with
out_mrc.header = header but separate setting of the attributes works nicely.
alisterburt
approved these changes
Jul 23, 2023
There was a problem hiding this comment.
Sorry for the delay here - just getting back to reality!
Main comment is I don't love that a flag dictates the return type in the load_tomogram function, I would rather return some simple model Tomogram with both the array data and the header in every case
non blocking though - can be followup/cleanup
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust dataloading to keep the header information of the input tomogram even after segmentation with MemBrain-seg.
It is not based on Pyto (as I thought initially would be necessary), but only on the mrcfile package. Thanks Alister for helping fix this!