makeVariables

[jfrolich]

I never did anything with ppx but this seems to pass tests. Any recommendations how to proceed. I only implemented the bucklescript side of things for now.

Resolves #33

[baransu]

I rebased it on top of the current master. GH Actions should work correctly right now.

Looks really good. Thank you! The native side should bs as straight forward as the BuckleScript part 🙂. After that, we can merge 😎

[jfrolich]

@baransu do you know of a good guide to understand ppx and the ocaml/reason AST? Perhaps especially documentation about how to use the Ast_helper module (it's not really documented).

[baransu]

@jfrolich In my case, I was learning as I go with graphql_ppx. I just follow https://caml.inria.fr/pub/docs/manual-ocaml/compilerlibref/Parsetree.html to know what to do basically and a lot of trial and error.

[jfrolich]

Awesome. ReasonML docs already makes it more readable. But pretty sparse docs indeed!

[jfrolich]

I added the makeVariables to native and the tests seem to pass. I could only run @402 for some reason.

[baransu]

LGTM 🎉 Thank you @jfrolich

[nirvdrum]

@jfrolich When you get a chance, would you mind adding something to the README? I'm sure I can pull together the info by looking at the PR, but I think a short paragraph with a code example would go a long way in helping others out.

[baransu]

@nirvdrum Created issue for that #55

[jfrolich]

Good point @nirvdrum.