Skip to content

Commit

Permalink
Skip the Maximize test for Selenium 3 and Firefox
Browse files Browse the repository at this point in the history
This method has a known issue:

mozilla/geckodriver#703
  • Loading branch information
minusnine committed May 10, 2017
1 parent 6afc630 commit 3a08bc2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ one.
4. [The Proxy object is
misinterpreted](https://github.com/mozilla/geckodriver/issues/490) by
Geckodriver when passed through by Selenium 3.
5. [Maximizing the browser window
hangs](https://github.com/mozilla/geckodriver/issues/703).

The Geckodriver team recommends using the newest available Firefox version, as
the integration is actively being developed.
Expand Down
4 changes: 4 additions & 0 deletions remote_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1288,6 +1288,10 @@ func testGetAttributeNotFound(t *testing.T, c config) {
}

func testMaximizeWindow(t *testing.T, c config) {
if c.seleniumVersion.Major == 3 && c.browser == "firefox" {
t.Skip("Skipping test due to https://github.com/mozilla/geckodriver/issues/703")
}

wd := newRemote(t, c)
defer quitRemote(t, wd)

Expand Down

0 comments on commit 3a08bc2

Please sign in to comment.