Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use named exports of react-helmet #458

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

ansgarprause
Copy link
Contributor

@ansgarprause ansgarprause commented Oct 14, 2019

The default export will be removed in react-helmet@6.0.0.

The corresponding type definition is currently missing in @types/react-helmet@5.0.11.
See also DefinitelyTyped/DefinitelyTyped#39094.

This is causing the following error.

TS2604: JSX element type 'Helmet' does not have any construct or call signatures.

The default export will be removed in version 6.0.0
and is currently missing in @types/react-helmet@5.0.11.
@ansgarprause ansgarprause changed the title Only use named imports of react-helmet Only use named exports of react-helmet Oct 14, 2019
@nimzco
Copy link
Member

nimzco commented Oct 14, 2019

😍 Thank you!

@nimzco nimzco merged commit a373482 into tech-conferences:master Oct 14, 2019
@ansgarprause ansgarprause deleted the react-helmet-named branch October 14, 2019 08:35
@nimzco
Copy link
Member

nimzco commented Oct 14, 2019

Successfully deployed! 👏

2CFF7F7E-6916-47D0-9BBD-B4316490B000

@perSimone
Copy link
Contributor

Yes! That was the error I got too. Great suff 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants