Skip to content

Chore: Satisfy link checker by ignoring example.org#174

Merged
amotl merged 2 commits intomainfrom
fix-linkchecker-example.org
Feb 25, 2026
Merged

Chore: Satisfy link checker by ignoring example.org#174
amotl merged 2 commits intomainfrom
fix-linkchecker-example.org

Conversation

@amotl
Copy link
Member

@amotl amotl commented Feb 25, 2026

Just maintenance.

@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

Walkthrough

Two URLs ("https://example.org" and "https://docutils.sourceforge.io/") were added to the linkcheck_ignore list in the Sphinx configuration file. This expands the set of domains excluded from link validation checks without altering any control flow or error handling logic.

Changes

Cohort / File(s) Summary
Link Checker Configuration
docs/conf.py
Added two URLs to the linkcheck_ignore list for Sphinx documentation link validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Chore: Fix broken links #171: Also modifies docs/conf.py to update the linkcheck_ignore configuration by adding URLs to the link checker ignore list.

Poem

🐰 Hopping o'er broken links so fine,
Two URLs now skip the line,
Example and Docutils grand,
Excused from checks across the land!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description 'Just maintenance.' is vague and generic, using non-descriptive language that doesn't convey meaningful information about the specific linkcheck configuration changes. Consider providing more detail about which URLs are being ignored and why, e.g., 'Add example.org and docutils.sourceforge.io to linkcheck_ignore list to fix failing checks.'
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title is partially related to the changeset, referring to one of two URLs added to linkcheck_ignore, but not covering the complete scope of the change which also includes docutils.sourceforge.io.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-linkchecker-example.org

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/conf.py`:
- Line 44: In the linkcheck_ignore list update the entry "https://example.org"
to include a trailing slash ("https://example.org/") for consistency with other
prefixes; locate the linkcheck_ignore definition in docs/conf.py and replace the
existing string so all entries use a trailing slash prefix, keeping the
surrounding list formatting intact.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55551e0 and ce824d9.

📒 Files selected for processing (1)
  • docs/conf.py

"https://jkalina.carrd.co/",
"https://simpleicons.org/",
"https://unsplash.com/",
"https://example.org",
Copy link

@coderabbitai coderabbitai bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add trailing slash to "https://example.org" for consistency.

Every other entry in linkcheck_ignore uses a trailing slash as a prefix delimiter. While re.search() makes this functionally equivalent for sub-path matching, the missing slash is an inconsistency worth aligning.

✏️ Proposed fix
-    "https://example.org",
+    "https://example.org/",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"https://example.org",
"https://example.org/",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/conf.py` at line 44, In the linkcheck_ignore list update the entry
"https://example.org" to include a trailing slash ("https://example.org/") for
consistency with other prefixes; locate the linkcheck_ignore definition in
docs/conf.py and replace the existing string so all entries use a trailing slash
prefix, keeping the surrounding list formatting intact.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but no: It would defy the pattern matching. Been there, seen that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amotl, understood! Thank you for the clarification. I appreciate you sharing that insight about the pattern matching behavior—it makes sense that the trailing slash affects how the patterns are matched in Sphinx's linkcheck configuration.

(\\_/)
(o.o)
(> <)  *learning noted*

✏️ Learnings added
Learnt from: amotl
Repo: tech-writing/sphinx-design-elements PR: 174
File: docs/conf.py:44-44
Timestamp: 2026-02-25T14:21:43.759Z
Learning: In Sphinx documentation configuration (docs/conf.py), the linkcheck_ignore list uses pattern matching where the presence or absence of a trailing slash affects matching behavior. For example, "https://example.org" (without trailing slash) may be needed to properly match the domain and all its paths, while adding a trailing slash could break the pattern matching. Developers with experience in this codebase have noted this specific behavior.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

@amotl amotl merged commit 5319c50 into main Feb 25, 2026
14 checks passed
@amotl amotl deleted the fix-linkchecker-example.org branch February 25, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant