Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make multiple options with comments responsive #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

berteh
Copy link

@berteh berteh commented Dec 18, 2014

Please pull this modification to make lists of multiple options with comments responsive.

@berteh
Copy link
Author

berteh commented Dec 18, 2014

only the first 2 commits are related to making multiple options with comments reponsive... the other commits are making other parts more responsive but I don't know how to "separate" this pull request from the other commits in my fork... sorry.
feel free to cherry pick the later commits or not, to your liking.

@grundm
Copy link
Contributor

grundm commented Jan 4, 2015

Hi Berteh,

Thanks for your contributions.

It is kind of tricky to follow your commits and hence to merge your pull request. Thus, it would be great if you could make single pull requests. Maybe the following stack overflow discussion is helpful for you: http://stackoverflow.com/questions/5256021/send-a-pull-request-on-github-for-only-latest-commit

Furthermore, it would be great if you could make a single commit out of duplicate commits (e.g. "responsive language chooser" or if you could use different messages.

Do you have a demo of the template?

Best, Martin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants