Small fix in cloning methods #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ichursin
commented
Jul 19, 2017
ichursin
commented
- add correct saving object prototype when we cloning data
* add correct saving object prototype
*trailing spaces
|
I'll try to look at this tonight... sounds similar to our not very well documented 'protos' functionality. Do you persist your data and if so are the protos attached correctly across saves? |
|
This seems to work great with some of the edge cases I threw at it (forceClones on chained data, as well as defining collection protos to inflate with in db constructor). We should probably cover all those edge cases better, I will look at that if I get a few minutes later... Thanks! |
Viatorus
added a commit
to LokiJS-Forge/LokiDB
that referenced
this pull request
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.