ELE-4208 Hook up instana to error logging #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddocash
force-pushed
the
ELE-4208-forwardErrorsToInstana
branch
from
2411e6d to
f1e12ce
Compare
pogotc
reviewed
Feb 25, 2021
| if (LOGGING_CONFIG.FORWARD_TO_NEWRELIC && $window.NREUM && $window.NREUM.noticeError) { | ||
| $window.NREUM.noticeError(exception, { url: $window.location.href }); | ||
| if (LOGGING_CONFIG.FORWARD_TO_INSTANA && typeof ineum !== undefined && ineum) { | ||
| ineum('reportError', exception); | ||
| } |
There was a problem hiding this comment.
It's all a bit academic as we're the only ones who use this library, but I still wonder if these changes should be in addition to NewRelic support instead of as a replacement
There was a problem hiding this comment.
I think as it's just us and we hopefully wont be using it be the end of the year, I'm going to leave it as is :)
pogotc
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Looks good to me, I do wonder if this should be adding support for Instana rather than replacing NewRelic with it, but I don't feel strongly enough about it to not approve the changes.
Only other thing to remember before merging is to bump the version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Github ticket
https://github.com/talis/elevate-app/issues/4208
Linked Instana docs
https://www.instana.com/docs/website_monitoring/api/#error-tracking
Change