Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove white color from .btn-alert:hover:focus state #64

Merged

Conversation

camillef
Copy link

@camillef camillef commented Oct 15, 2020

Problem

When a button with the btn-alert class applied is focussed and hovered at the same time, the text turns white, which is not readable

Example

The third button in this screenshot is hovered and focussed
image

Fix

Remove the white color from .btn-alert:hover:focus state

@@ -263,7 +259,7 @@
}

&:hover:active {
background-color: #gray800;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken window: typo

@danielmatthew danielmatthew merged commit 3af5f16 into master Oct 15, 2020
@danielmatthew danielmatthew deleted the remove-white-color-from-btn-alert-hover-focus-state branch October 15, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants