TA-1362: Update bootstrap 3 theme to match branding #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksenijamv
reviewed
Aug 9, 2024
darren-arbon
commented
Aug 9, 2024
| @@ -155,7 +155,7 @@ | |||
| .navbar-brand { | |||
| float: left; | |||
| height: $navbar-height; | |||
| padding: $navbar-padding-vertical $navbar-padding-horizontal; | |||
| padding: 15px $navbar-padding-horizontal 15px $navbar-padding-horizontal; | |||
There was a problem hiding this comment.
we overwrite this in dc anyway, so makes sense to have it here?
…ed in new favicon
TomBirbeckTFS
temporarily deployed
to
github-pages
pogotc
reviewed
Aug 14, 2024
| } | ||
|
|
||
| .c-error-page__subheader { | ||
| font-size: floor($font-size-base * 3); | ||
| color: $white; | ||
| color: $black; | ||
| } |
There was a problem hiding this comment.
I think you can just remove these color entries and it'll pick up the global text colour, which should be $gray700 instead of $black
|
This is looking good to me, just the one issue with the text colour on the error page but it can go in once that's sorted. We can address the loader colours as a follow up |
TomBirbeckTFS
temporarily deployed
to
github-pages
pogotc
approved these changes
Aug 14, 2024
…lly auto picks it up
TomBirbeckTFS
temporarily deployed
to
github-pages
TomBirbeckTFS
temporarily deployed
to
github-pages
TomBirbeckTFS
temporarily deployed
to
github-pages
TomBirbeckTFS
temporarily deployed
to
github-pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently available here: https://talis.github.io/bootstrap-sass/#
For a comparison, use the bootstrap 5 version: https://talis.github.io/bootstrap-theme/#
UX Design Brief can be found here: https://techfromsage.atlassian.net/wiki/spaces/UT/pages/1122238467/Talis+Aspire+Rebrand+2024
Marketing Brief can be found here: https://sagecrm.sharepoint.com/sites/LeanLibrarySalesandMarketing/Shared%20Documents/Forms/AllItems.aspx?id=%2Fsites%2FLeanLibrarySalesandMarketing%2FShared%20Documents%2FMarketing%2F2%2E%20Branding%2F8%2E%20Rebrand%2FFINAL%20Rebrand%20Assets%2FProduct%20Rebrand%20Pack%20%2D%20Talis%2FBrand%20Guidelines%2FTechnology%20from%20Sage%5FBrand%20toolkit%20v9%2Epdf&parent=%2Fsites%2FLeanLibrarySalesandMarketing%2FShared%20Documents%2FMarketing%2F2%2E%20Branding%2F8%2E%20Rebrand%2FFINAL%20Rebrand%20Assets%2FProduct%20Rebrand%20Pack%20%2D%20Talis%2FBrand%20Guidelines