Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Move Talis customisations to own partial #17

Merged
merged 18 commits into from
Feb 28, 2022

Conversation

danielmatthew
Copy link
Contributor

@danielmatthew danielmatthew commented Feb 28, 2022

Per Bootstrap's documentation on customisation, this PR specifies a _theme partial, meaning it can sit on top of Bootstrap v5.

Option A: Include all of Bootstrap (185kb)

// custom.scss


// Include any default variable overrides here (though functions won't be available)
@import "bootstrap-theme/scss/variables";
// Assumes Sass load-path includes node_modules
@import "bootstrap/scss/bootstrap"; 

// Then add additional custom code here
@import "bootstrap-theme/scss/theme";

Option B: Include only parts of Bootstrap we use (163kb)

// custom.scss


// 1. Include functions first (so you can manipulate colors, SVGs, calc, etc)
// Assumes Sass load-path includes node_modules
@import "bootstrap/scss/functions";

// 2. Include any default variable overrides here
@import "bootstrap-theme/scss/variables";

// 3. Include remainder of required Bootstrap stylesheets
@import "bootstrap/scss/variables";
@import "bootstrap/scss/mixins";
@import "bootstrap/scss/utilities";

// 4. Include any optional Bootstrap components as you like
@import "bootstrap/scss/root"; 
@import "bootstrap/scss/reboot";
@import "bootstrap/scss/type";
@import "bootstrap/scss/images";
@import "bootstrap/scss/containers";
@import "bootstrap/scss/grid";
@import "bootstrap/scss/tables";
@import "bootstrap/scss/forms";
@import "bootstrap/scss/buttons";
@import "bootstrap/scss/transitions";
@import "bootstrap/scss/dropdown";
@import "bootstrap/scss/button-group";
@import "bootstrap/scss/nav";
@import "bootstrap/scss/navbar";
@import "bootstrap/scss/accordion";
@import "bootstrap/scss/breadcrumb";
@import "bootstrap/scss/pagination";
@import "bootstrap/scss/badge";
@import "bootstrap/scss/alert";
@import "bootstrap/scss/progress";
@import "bootstrap/scss/close";
@import "bootstrap/scss/toasts";
@import "bootstrap/scss/modal";

// Helpers
@import "bootstrap/scss/helpers";

// Utilities
@import "bootstrap/scss/utilities/api";

// 5. Add additional custom code here
@import "bootstrap-theme/scss/theme";

@danielmatthew danielmatthew merged commit f11e808 into main Feb 28, 2022
@danielmatthew danielmatthew deleted the split-out-theme branch February 28, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant