Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #158773 chore: Rating Field in TjUcm #363

Open
wants to merge 5 commits into
base: release-1.2.4
Choose a base branch
from

Conversation

shraddhaSankpal27
Copy link

No description provided.

@@ -22,3 +22,66 @@ width:200px !important;
.tjucm-wrapper .tj-wordwrap{
word-break: break-word;
}

/****** Style Star Rating Widget *****/
fieldset, label { margin: 0; padding: 0; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shraddhaSankpal27 direct CSS for bootstrap classes are not recommended, use UCM wrapper class with the CSS class.

e.g .ucm-wrapper .label{
CSS
}

Again, this can cause issues in other fields label and ieldsets. We should not write CSS for generic classes of bootstrap. The input and label should use template CSS only

Copy link
Author

@shraddhaSankpal27 shraddhaSankpal27 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankush-maherwal I'll update with help of designer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankush-maherwal @shraddha : Update the generic css for rating and also rating star use
images that will good option.

@shraddhaSankpal27 shraddhaSankpal27 changed the title Feature #158773 chore: Rating Field in TjUcm Feature #158773 chore: Rating Field in TjUcm and Feature #163832 chore: Implement Multiple Copy feature on the frontend listing Aug 17, 2020
@shraddhaSankpal27 shraddhaSankpal27 changed the title Feature #158773 chore: Rating Field in TjUcm and Feature #163832 chore: Implement Multiple Copy feature on the frontend listing Feature #158773 chore: Rating Field in TjUcm Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants