-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace open
property on close
event with separate close
and closeAttempt
events in Dialogs and Drawers
#468
Merged
techniq
merged 8 commits into
techniq:main
from
brandonmcconnell:svelte-ux_brandonmcconnell-closeAttempt
Aug 16, 2024
Merged
Replace open
property on close
event with separate close
and closeAttempt
events in Dialogs and Drawers
#468
techniq
merged 8 commits into
techniq:main
from
brandonmcconnell:svelte-ux_brandonmcconnell-closeAttempt
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
🦋 Changeset detectedLatest commit: 9ae17f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
brandonmcconnell
changed the title
Replace
Replace Aug 16, 2024
close
open
property with close
and closeAttempt
eventsopen
property on close
event with close
and closeAttempt
events in in Dialogs and Drawers
brandonmcconnell
changed the title
Replace
Replace Aug 16, 2024
open
property on close
event with close
and closeAttempt
events in in Dialogs and Drawersopen
property on close
event with close
and closeAttempt
events in Dialogs and Drawers
brandonmcconnell
changed the title
Replace
Replace Aug 16, 2024
open
property on close
event with close
and closeAttempt
events in Dialogs and Drawersopen
property on close
event with separate close
and closeAttempt
events in Dialogs and Drawers
techniq
approved these changes
Aug 16, 2024
Merged
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.