Skip to content

Conversation

@0xmiki
Copy link
Contributor

@0xmiki 0xmiki commented Jun 17, 2025

  • Update the example app.css to include:
    -@layer base { *, ::after, ::before, ::backdrop, ::file-selector-button { border-color: color-mix( in oklab, var(--color-surface-content) 20%, transparent ); outline-color: color-mix( in oklab, var(--color-surface-content) 20%, transparent ); } }
    • For borders to look nice
  • Removed tailwind v3 customization guide and added v4
    • But needs further improvement

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2025

⚠️ No Changeset found

Latest commit: d2a2cb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 17, 2025

Open in StackBlitz

npm i https://pkg.pr.new/svelte-ux@610

commit: d2a2cb5

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
svelte-ux ❌ Failed (View Log) d2a2cb5

@0xmiki
Copy link
Contributor Author

0xmiki commented Jun 17, 2025

hmm I tried making these updates but for some reason my next branch is not similar to the next website deployed in production

@0xmiki
Copy link
Contributor Author

0xmiki commented Jun 17, 2025

Oh never mind I was looking at the wrong domain
https://next.svelte-ux.pages.dev/ 😅

@0xmiki 0xmiki reopened this Jun 17, 2025
@0xmiki
Copy link
Contributor Author

0xmiki commented Jun 17, 2025

I just caught this, when using with layerchart it should be
@source '../../node_modules/layerchart/dist';
but the docs say:
@source '../../node_modules/@layerchart/dist';
in app.css

also the comments need to be in /* */ format instead of //

Comment on lines 46 to 107
html {
@apply bg-surface-200 accent-primary scroll-smooth;
/* background-image:
radial-gradient(at 0% 0%, hsl(var(--color-secondary) / 0.33) 0px, transparent 50%),
radial-gradient(at 98% 1%, hsl(var(--color-primary) / 0.33) 0px, transparent 50%); */
}

nav h1 {
@apply py-2 pl-4 mt-4 text-sm text-surface-content font-bold bg-surface-200 border-t border-b;
}

nav h2 {
@apply pt-4 pb-2 pl-4 text-xs text-surface-content font-bold;
}

.prose {
h1 {
@apply text-2xl font-extrabold;
}
h2 {
@apply text-xl font-bold mt-3;
}
h3 {
@apply text-lg font-semibold;
}
}

main :is(h1, h2, h3):not(.prose *, .related *, .ApiDocs *) {
scroll-margin-top: calc(var(--headerHeight) + 148px); /* app header + docs header */
}

main h1:not(.prose *, .related *, .ApiDocs *) {
@apply text-xl font-semibold mt-4 mb-2 border-b pb-1;
}

main h2:not(.prose *, .related *, .ApiDocs *) {
@apply text-lg font-semibold mt-4 mb-1;
}

main h3:not(.prose *, .related *, .ApiDocs *) {
@apply text-xs text-surface-content/50 mb-1;
}
main :not(.prose) h2 + h3 {
@apply -mt-1;
}

main small {
@apply text-xs text-surface-content/50 inline-block;
}

.TableOfContents small {
@apply hidden;
}

/* Code/Preview backgrounds */
pre[class*='language-'] {
@apply bg-surface-content;
}

.dark pre[class*='language-'] {
@apply bg-surface-300;
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly of these are specific to the docs. The one possibly worth calling out is setting the html background and maybe setting the accent-color (for normal <input> if used)

html {
  @apply bg-surface-200 accent-primary;
}

@techniq
Copy link
Owner

techniq commented Jun 17, 2025

Thanks for reviewing and updating the docs. Let me know when you think this one is ready.

I just caught this, when using with layerchart it should be
@source '../../node_modules/layerchart/dist';
but the docs say:
@source '../../node_modules/@layerchart/dist';
in app.css

also the comments need to be in /* */ format instead of //

Good catches. Fixed on next

@0xmiki
Copy link
Contributor Author

0xmiki commented Jun 17, 2025

Ok will do
so should i close this PR? Or resolve the conflict?

@techniq
Copy link
Owner

techniq commented Jun 17, 2025

Ok will do so should i close this PR?

No need. You can continue to make changes to your branch (0xmiki:next) and they will reflect on this PR. We can just iterate on this PR if that works for you. You can also switch the PR to draft (see the "Convert to draft" link towards to top) and then remove draft status when you're ready.

Also, whatever works best for you. Just some ideas.

@techniq
Copy link
Owner

techniq commented Jun 17, 2025

@0xmiki you'll want to merge in next to fix the conflicts in routes/+page.svelte. Some of your recent changes were also made upstream in next.

image

@0xmiki
Copy link
Contributor Author

0xmiki commented Jun 17, 2025

Sorry about that I'm still learning how to use git 😅

did i break the PR

@techniq
Copy link
Owner

techniq commented Jun 17, 2025

No worries! We all have to learn.

Hmm... it does look like this PR no longer has any commits (i.e. your fork's next branch is identical to this repo's next). If you reapply your changes now it should work (and we'll re-open this PR).

@0xmiki 0xmiki reopened this Jun 17, 2025
@github-actions github-actions bot requested a deployment to Preview June 17, 2025 14:01 Abandoned
@0xmiki
Copy link
Contributor Author

0xmiki commented Jun 17, 2025

Hmm, I see the changes to the css got merged here. Are there any other tweaks needed from my end?

@techniq
Copy link
Owner

techniq commented Jun 17, 2025

You had updated the theme customization section to show the CSS variables instead of tailwind plugin/config.

image

@0xmiki
Copy link
Contributor Author

0xmiki commented Jun 18, 2025

Ok great, sorry my confusion 😅

I am really hyped about using this stack as my main driver, hoping to make more succesful PRs next time tho lol

@0xmiki 0xmiki closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants