Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message names that start with non alphabetic char #41

Merged
merged 5 commits into from
Apr 21, 2021
Merged

Fix message names that start with non alphabetic char #41

merged 5 commits into from
Apr 21, 2021

Conversation

andresv
Copy link
Contributor

@andresv andresv commented Apr 16, 2021 •
edited
Loading

@andresv andresv mentioned this pull request Apr 16, 2021
Open
@andresv
Copy link
Contributor Author

andresv commented Apr 21, 2021

@killercup do you have any comments about this PR?

@killercup
Copy link
Member

Thanks for the ping and sorry for the wait!

This looks good to me, nothing I'd do differently -- I'll merge it immediately :)

@killercup killercup merged commit b062b9a into technocreatives:main Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle lead underscore in message name
2 participants
@andresv @killercup