Skip to content

Respect impl_arbitrary config when importing arbitrary #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2024
Merged

Respect impl_arbitrary config when importing arbitrary #83

merged 3 commits into from
Aug 28, 2024

Conversation

scootermon
Copy link
Contributor

If the user passes FeatureConfig::Gated with any value other than "arb" the generated code is currently invalid. Same goes for when the user uses FeatureConfig::Always.

killercup
killercup approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look too closely at this but looks okay. I see you're actively trying to use this so I won't stand in your way :)

@killercup killercup merged commit 6283aa4 into technocreatives:main Aug 28, 2024
2 checks passed
@scootermon scootermon deleted the fix-arb-gate branch August 28, 2024 14:49
@scootermon
Copy link
Contributor Author

Haha, I can assure you it "works on my machine". I definitely want to make an effort to provide some solid test cases for this when I get the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killercup killercup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scootermon @killercup