-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/auth via supabase #203
Conversation
auth0 still kept in to make the transition easier
to make clear that it is using auth0
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ng/giessdenkiez-de-postgres-api into feat/auth-via-supabase
If not it ends up as url param
Before validation
…ng/giessdenkiez-de-postgres-api into feat/auth-via-supabase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two comments for you.
The commit where you keep v2 and v3 was quite complex but looked good to me imho.
very good, that you removed some unused routes on the fly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Can't say too much because I'm not overly familiar with this codebase)
Surely challenging to make this migration from one auth solution to another. It looks very thoroughly tested, that's great! If our manual testing is also successful, let's move on with this!
Found one small issue in the README, that's all.
@all-contributors add @dnsos for review |
I've put up a pull request to add @dnsos! 🎉 |
@all-contributors @julizet for review |
I could not determine your intention. Basic usage: @all-contributors please add @Someone for code, doc and infra For other usages see the documentation |
@all-contributors add @julizet for review |
I've put up a pull request to add @julizet! 🎉 |
This PR adds authentication using Supabase. All that use supabase are now under
/api/v3/[get|delete|post]
.We still support the auth using auth0 for a smoother transistion. The api can already be found under https://supabase.api.giessdenkiez.de/
This is a major refactor. I know but we need this to reuse code in routes