Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/auth via supabase #203

Merged
merged 29 commits into from
Mar 23, 2023
Merged

feat/auth via supabase #203

merged 29 commits into from
Mar 23, 2023

Conversation

ff6347
Copy link
Collaborator

@ff6347 ff6347 commented Mar 17, 2023

This PR adds authentication using Supabase. All that use supabase are now under /api/v3/[get|delete|post].
We still support the auth using auth0 for a smoother transistion. The api can already be found under https://supabase.api.giessdenkiez.de/

This is a major refactor. I know but we need this to reuse code in routes

@vercel
Copy link

vercel bot commented Mar 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
giessdenkiez-de-postgres-api ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 23, 2023 at 7:55PM (UTC)

Copy link
Member

@julizet julizet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two comments for you.
The commit where you keep v2 and v3 was quite complex but looked good to me imho.

very good, that you removed some unused routes on the fly :)

api/v3/delete/[type].ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dnsos dnsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Can't say too much because I'm not overly familiar with this codebase)

Surely challenging to make this migration from one auth solution to another. It looks very thoroughly tested, that's great! If our manual testing is also successful, let's move on with this!

Found one small issue in the README, that's all.

README.md Outdated Show resolved Hide resolved
@ff6347
Copy link
Collaborator Author

ff6347 commented Mar 23, 2023

@all-contributors add @dnsos for review

@allcontributors
Copy link
Contributor

@ff6347

I've put up a pull request to add @dnsos! 🎉

@ff6347
Copy link
Collaborator Author

ff6347 commented Mar 23, 2023

@all-contributors @julizet for review

@allcontributors
Copy link
Contributor

@ff6347

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@ff6347
Copy link
Collaborator Author

ff6347 commented Mar 23, 2023

@all-contributors add @julizet for review

@allcontributors
Copy link
Contributor

@ff6347

I've put up a pull request to add @julizet! 🎉

@ff6347
Copy link
Collaborator Author

ff6347 commented Mar 23, 2023

@dnsos @julizet Thanks for your reviews. I guess I will merge this into staging so we can start manually testing this. I also need it to test user import from Auth0.

@ff6347 ff6347 merged commit 8713149 into staging Mar 23, 2023
@ff6347 ff6347 deleted the feat/auth-via-supabase branch March 23, 2023 20:02
@ff6347 ff6347 restored the feat/auth-via-supabase branch March 24, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants