fix(profile): Make usernames case insensitive #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by using the citext extensions. Once we have imported all the users from auth0 we will remove the uuid trigger function and only have the DB reject duplicate names
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The function was not able to find the uuid_generate_v4 function
These test check some beahaviour in the schema - adding uuid to username on duplicates (needed 4 migration from auth0) - cascading removal of users data from the database - change of username on trees_watered on change of username in profile
|
@julizet @raphael-arce @dnsos Maybe you see something that I missed? |
dnsos
reviewed
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This is done by using the citext extensions.
Once we have imported all the users from auth0 we will remove the
uuid trigger function and only have the DB reject duplicate names
The trigger function that adds an uuid to the username if we have duplicates did throw an error when executed by adding a user with the same name as an existing one. This still will be removed when we are migrated.
Test
This surfaced some errors we had in the schema. Like you can see in the fixes above