Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use fixed size modal #587

Merged
merged 3 commits into from
May 23, 2023
Merged

Conversation

raphael-arce
Copy link
Contributor

No description provided.

…lity with current jest setup

Signed-off-by: Raphael Arce <raphael.arce@ts.berlin>
@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giessdenkiez-de ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2023 8:25am

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@supabase/auth-helpers-nextjs@0.6.0 0.6.1...0.6.0 None +2/-2 phamhieu1998

@ff6347
Copy link
Collaborator

ff6347 commented May 16, 2023

Are you going to alter all the modals?

we have a modals for:

  • Password edit
  • Account Edit (Email/Username)
  • Watering Modal

Copy link
Collaborator

@dnsos dnsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this prevents the jumping indeed!

I would like to discuss the implementation of the NotificationPlaceholder, see my comment below.

src/components/NotificationPlaceholder/index.tsx Outdated Show resolved Hide resolved
@raphael-arce
Copy link
Contributor Author

raphael-arce commented May 16, 2023

@ff6347 I forgot to mention it, but I wanted to discuss the approach with you guys, while implementing I noticed that other modals have sometimes multiple notifications, therefore only one placeholder/spacer would not work in that case.

@dnsos yes I agree with all your points. Maybe we can discuss it further in a call, to see if we should at the same time find solutions regarding modals where multiple notifications are possible at the same time?

Signed-off-by: Raphael Arce <raphael.arce@ts.berlin>
Copy link
Collaborator

@dnsos dnsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Thanks for the changes!

@dnsos
Copy link
Collaborator

dnsos commented May 17, 2023

therefore only one placeholder/spacer would not work in that case.

Yes, I can see the issue. I'm open to discussing other approaches, but also happy to merge this for now and do it afterwards.

@ff6347 ff6347 merged commit 80f3d44 into feat/auth-via-supabase May 23, 2023
@ff6347 ff6347 deleted the feat/use-fixed-size-modal branch May 23, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants