-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use fixed size modal #587
Conversation
…lity with current jest setup Signed-off-by: Raphael Arce <raphael.arce@ts.berlin>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
Are you going to alter all the modals? we have a modals for:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this prevents the jumping indeed!
I would like to discuss the implementation of the NotificationPlaceholder
, see my comment below.
@ff6347 I forgot to mention it, but I wanted to discuss the approach with you guys, while implementing I noticed that other modals have sometimes multiple notifications, therefore only one placeholder/spacer would not work in that case. @dnsos yes I agree with all your points. Maybe we can discuss it further in a call, to see if we should at the same time find solutions regarding modals where multiple notifications are possible at the same time? |
Signed-off-by: Raphael Arce <raphael.arce@ts.berlin>
bc3d2f3
to
3ca61fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! Thanks for the changes!
Yes, I can see the issue. I'm open to discussing other approaches, but also happy to merge this for now and do it afterwards. |
No description provided.