-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove deckgl, remove rain layer #692
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I removed the tests for pump color, because now with mapbox-gl only, we use Expressions, which get the properties from the MapboxGL layer directly which is not possible directly. There is an active discussion on how to do it: mapbox/mapbox-gl-js#7670 but adding the mentioned library https://www.npmjs.com/package/mapbox-expression to the project introduces dependency conflicts. |
Closing for now, we might want to do this at a later point when doing the UI rework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- legend.precipitationAreas can now be deleted from the translation file I think?
- the zoom speed seems a bit too fast for me when scrolling
- otherwise LGTM :)
@aeschi Thanks! I fine tuned zoom speed and removed dead code |
Don't merge yet, waiting for PO approval @HenrietteN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty snappy. Me like!
easeTo
instead of manipulating the viewport manually