Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deckgl, remove rain layer #692

Merged
merged 15 commits into from
Feb 19, 2024
Merged

Conversation

Jaszkowic
Copy link
Collaborator

@Jaszkowic Jaszkowic commented Feb 12, 2024

  • Remove Deck.gl completely
  • Remove rain layer
  • Let Mapbox handle the viewport itself, use easeTo instead of manipulating the viewport manually
  • Customize zoom rate for smoother zooming

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giessdenkiez-de ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 8:21am

@Jaszkowic
Copy link
Collaborator Author

I removed the tests for pump color, because now with mapbox-gl only, we use Expressions, which get the properties from the MapboxGL layer directly which is not possible directly. There is an active discussion on how to do it: mapbox/mapbox-gl-js#7670 but adding the mentioned library https://www.npmjs.com/package/mapbox-expression to the project introduces dependency conflicts.

@Jaszkowic Jaszkowic marked this pull request as draft February 12, 2024 14:38
@Jaszkowic Jaszkowic changed the title chore: remove deckgl, remove rain layer WIP chore: remove deckgl, remove rain layer Feb 12, 2024
@Jaszkowic
Copy link
Collaborator Author

Closing for now, we might want to do this at a later point when doing the UI rework.

@Jaszkowic Jaszkowic closed this Feb 13, 2024
@Jaszkowic Jaszkowic reopened this Feb 14, 2024
@Jaszkowic Jaszkowic changed the title WIP chore: remove deckgl, remove rain layer fix: remove deckgl, remove rain layer Feb 14, 2024
@Jaszkowic Jaszkowic marked this pull request as ready for review February 14, 2024 10:11
Copy link
Contributor

@aeschi aeschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • legend.precipitationAreas can now be deleted from the translation file I think?
  • the zoom speed seems a bit too fast for me when scrolling
  • otherwise LGTM :)

@Jaszkowic
Copy link
Collaborator Author

@aeschi Thanks! I fine tuned zoom speed and removed dead code

@Jaszkowic
Copy link
Collaborator Author

Don't merge yet, waiting for PO approval @HenrietteN

Copy link
Collaborator

@ff6347 ff6347 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty snappy. Me like!

@Jaszkowic Jaszkowic merged commit 4335bad into staging Feb 19, 2024
7 checks passed
@Jaszkowic Jaszkowic deleted the chore/remove-deck-gl branch February 19, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants