Feat/embedding events to attraction #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edding-events-to-attraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hier wird ein Boolean 'withEvents' zu den Abfragen "GET /attractions" und "GET /attractions/{identifier}" hinzugefügt, der es erlaubt, alle zu den abgefragten Attractions gehörigen Events mit abzufragen. Der Response enthält hierfür neben der Property "data" die Property "related" mit den entsprechenden Events.
Es ist Absicht, dass diese nicht Teil der jeweiligen Attraction sind, sondern alle in einem Array stehen. Die Performance wäre sonst (noch) schlechter und der typische Anwendungsfall ist, dass man die Events mit entsprechendem Attractions-Titel anzeigen möchte und nicht die Attractions. Also, eine Liste mit allen Events, die bestimmte Kriterien bzgl. Attraction beinhalten.