-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new organizationTags json #98
feat: new organizationTags json #98
Conversation
update the seeder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich habe jetzt mal nur die deutschen und englischen Varianten gecheckt und noch ein paar Kleinigkeiten gefunden, die wir vor dem Merge ausbessern sollten.
src/seed/organizationTags.json
Outdated
"identifier": "organization.category.IndependentArtist", | ||
"title": { | ||
"de": "Freie Künstler:in / Gruppe / Kollektiv", | ||
"en": "Free Artist / Group / Collective", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich glaube, hier wäre "Independent" statt "Free" passender (wie auch im identifier
und bei den anderen Übersetzungen)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unbedingt. Ich habe die Übersetzungen generieren lassen. Da finden sich sicherlich auch einige Fehler in den Sprachen, die ich nicht beherrsche. Wäre aber sicher wichtig, dass wir im Englischen korrekt sind. Danke dafür.
src/seed/organizationTags.json
Outdated
"type": "type.Tag", | ||
"identifier": "organization.category.Theater.PuppetFigureObjectTheater", | ||
"title": { | ||
"de": "Puppen- / Figuren-/ Objekttheater", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hier sind die Leerzeichen zwischen den Slashes nicht konsistent. 👮
"de": "Puppen- / Figuren-/ Objekttheater", | |
"de": "Puppen- / Figuren- / Objekttheater", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super. Ich habe die Texte 1 zu 1 von der alten Webseite übernommen.
src/seed/organizationTags.json
Outdated
"type": "type.Tag", | ||
"identifier": "organization.category.GalleryExhibitionSpaceInitiative", | ||
"title": { | ||
"de": "Galerie / Ausstellungsstätte / Initative für Bildende Kunst", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"de": "Galerie / Ausstellungsstätte / Initative für Bildende Kunst", | |
"de": "Galerie / Ausstellungsstätte / Initiative für Bildende Kunst", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super. Ich habe die Texte 1 zu 1 von der alten Webseite übernommen. Gut, wenn wir da Fehler verbessern.
src/seed/organizationTags.json
Outdated
"identifier": "organization.category.LibraryArchive.SpecializedLibrary", | ||
"title": { | ||
"de": "Spezial- / Fachbibliothek", | ||
"en": "Specialized / Fach Library", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Fach Library" ist hier wahrscheinlich nicht korrekt, oder? dict.cc sagt, das könnte entweder "special library" oder "technical library" sein.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ich denke hier wurde nicht special library genommen, um sich nicht zu wiederholen.
Ich denke Specialized Library reicht hier, oder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja, ich stimme zu – Specialized Library reicht hier!
Änderungen eingebaut. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, ab damit!
eine json mit generierten Kategorien inklusive Übersetzungen.