test: refactor tests to typescript and fix test configuration #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/typescript-refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
=========================================
+ Coverage 0 93.10% +93.10%
=========================================
Files 0 6 +6
Lines 0 58 +58
Branches 0 1 +1
=========================================
+ Hits 0 54 +54
- Misses 0 4 +4 |
…feature/typescript-refactor
| }, | ||
| cancelKeyText: 'cancelKeyText', | ||
| onCancelPress: jest.fn(), | ||
| onSubmitPress: jest.fn(), | ||
| submitKeyText: 'submitKeyText', | ||
| visible: false, | ||
| children: null | ||
| visible: true, |
There was a problem hiding this comment.
why we changed visibility in test?
There was a problem hiding this comment.
React Native made a breaking change in Modal mock where they disabled rendering of children when visible={false}: facebook/react-native#32346
Original package was using 0.57.2 where this change wasn't implemented yet.
rostislav-simonik
approved these changes
Apr 4, 2023
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.