[Bug] - npm run dev doesnt work

[Mcbencrafter]

What bug did you find in the codebase?

When running npm run dev, i get this error:

error when starting dev server:
TypeError: Cannot read properties of null (reading 'toString')
    at consolidateSnippets (file:///C:/Users/ben/Documents/quicksnip/vite.config.ts.timestamp-1737389347610-d862440f87b4c.mjs:14:14)  
    at configResolved (file:///C:/Users/ben/Documents/quicksnip/vite.config.ts.timestamp-1737389347610-d862440f87b4c.mjs:23:9)        
    at file:///C:/Users/ben/Documents/quicksnip/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:66405:67
    at Array.map (<anonymous>)
    at resolveConfig (file:///C:/Users/ben/Documents/quicksnip/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:66405:53)
    at async _createServer (file:///C:/Users/ben/Documents/quicksnip/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:62758:18)     
    at async CAC.<anonymous> (file:///C:/Users/ben/Documents/quicksnip/node_modules/vite/dist/node/cli.js:735:20)

I think this happens when the spawnSync command in vite.config.ts fails
Probraply tsx isnt in my path / the path of most people and therefore starting tsx doesnt work

[Mcbencrafter]

I changed the tsx location to the file in node_modules and now it seems to work, but i really dont know if this is the right way to fix it because I am not that good at typescript

[Mathys-Gasnier]

It's because we should use npx tsx ..., as npm modules aren't added to the path of the terminal

[erison7596]

The issue was caused by attempting to call .toString() on cmd.output in the vite.config.ts file, which can be null in some cases. Since spawnSync does not always populate the output array correctly, trying to convert it to a string resulted in a TypeError. The solution was simply to remove the console.log statement that attempted to print cmd.output.toString().

[Mcbencrafter]

But this doesnt solve the root cause of the tsx command unable to execute. The fix should probraply like Mathys-Gasnier said. But what you mentioned could probraply also fix some edgecases 👍

Did someone already fix this or is this still an issue on main?

[Mathys-Gasnier]

I've not seen any PR fixing this, so it's still most probably on main.
And I don't think the .toString causes any issues, if the command doesn't return an output, then it returned an error, and it should fail.
But yeah adding a check and printing the error in those cases might be a good idea.

[technoph1le]

Fixed the issue with the following commit.

Let me know what you think and what I might have missed.

[Mathys-Gasnier]

Looks good to me, closing as fixed