Skip to content

Use Escape key to close snippet modal #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 29, 2024
Merged

Conversation

jacobtyq
Copy link
Contributor

  • This PR adds the support of using the Escape key to close the snippet modal

escape

Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for quicksnip ready!

Name Link
🔨 Latest commit 0a2ee6b
🔍 Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/67710447b064e50008b08848
😎 Deploy Preview https://deploy-preview-2--quicksnip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@technoph1le
Copy link
Owner

Thank you very much for including this feature 👍. And, I also noticed that there are single quotations '' in your code instead of our standard double quotation "". I would appreciate your review on that.

@technoph1le technoph1le added the enhancement New feature or request label Dec 29, 2024
@jacobtyq
Copy link
Contributor Author

Thank you very much for including this feature 👍. And, I also noticed that there are single quotations '' in your code instead of our standard double quotation "". I would appreciate your review on that.

I reverted the prettier changes.

Sidenote, would you be including a prettier configuration file to standardise code formatting?

@technoph1le
Copy link
Owner

Sidenote, would you be including a prettier configuration file to standardise code formatting?

Yes, we also opened issue #9 on it as well. Will add it soon.

@technoph1le technoph1le merged commit afae80d into technoph1le:main Dec 29, 2024
4 checks passed
Mathys-Gasnier pushed a commit that referenced this pull request Jan 7, 2025
ACR1209 pushed a commit to ACR1209/quicksnip that referenced this pull request Jan 10, 2025
ACR1209 pushed a commit to ACR1209/quicksnip that referenced this pull request Jan 10, 2025
Fix cuz description was messed up

Consolidate for the Prime Number Description

Updated combinations.md

Removing end of line prettier config as it's not needed anymore

snippets: hex to rgb color

snippets: rgb to hsl color

snippets: hsl to rgb color

refactor: optimized rgb to hsl color

fix: hex to rgb color

Added Sorting and Search Algorithms to C (technoph1le#199)

Update consolidated snippets

Updating to use vite HMR to consolidate snippets

Changing status check in plugin

Snippets c++ (technoph1le#103)

* [C++] added snippet

* [C++] added 3 snippets for string.

* Added missing chrono header

* fixed tags

* fixed exemple needing std=c++20

* Fixed Usage to accommodate to new guidelines

* Fixed all tags + type

* Revert "Fixed all tags + type"

This reverts commit aebefde.

* Fixed type and all tags

* fixed  gh check failing

* Update consolidated snippets

* Update consolidated snippets

* Update consolidated snippets

* Revert "Merge remote-tracking branch 'origin/main' into snippets-c++"

This reverts commit 4708bd9, reversing
changes made to a959e95.

* Update consolidated snippets

---------

Co-authored-by: GitHub Action <action@github.com>

java date-time formatting snippets

added duration formatting

removed language from tags

enforced formatting requirements

Renamed and improved python truncate snippet

Renamed from `truncate-string.py` to `truncate.py`
Replaced "..." with ellipses("…") to only use one character
Implemented toggle for the `suffix` "…" on string with default of `True`

Update reverse-string.md

Added type hints

Renamed `remove-specific-characters.md` to `remove-characters.md`

Improved accuracy of Description for `convert-string-to-ascii` for better functional representation

Renamed `convert-string-to-ascii.md` to `convert-string-to-unicode.md`
Replaced ASCII with Unicode
Kept `ascii` tag as it is a subset of unicode and to minimize search errors

Fixed issue technoph1le#192

Update CONTRIBUTING.md

Added a `not` on line 68 in "Does that snippet have a real, and practical use case ?" to prevent useless snippets from being acceptable and useful snippets from being denied.

Rectified loss of attribution

recovered old attribution in the python snippet`truncate` to axorax and added the contributors tag.

truncate.md reconformed to PEP 8

removed Tab

Update truncate.md

Replaced "…" with "..."
Updated Description to match

Update reverse-string.md

followed change request

Miner miner mods refactor 1 (technoph1le#2)

2nd integration

feat: update snippet button and modal

increased the size of the snippet modal, added a bit more responsitivity too

removed the gray filter on  the snippet button

feat: add minimum width to modal

Added bash as a new language, also added a category and a snippet (technoph1le#204)

* Added a bash as a new language, also added a category and a snippet

* Fixed the snippet to make it more like a snippet

* Deleted public/consolidated/ and put code into a function

* Deleted public/consolidated/

Update calculate-compound-interest.md

Create Calculate-factorial.md

Rename Calculate-factorial.md to calculate-factorial.md

Update calculate-factorial.md

Delete snippets/python/math-and-numbers/calculate-factorial.md

refacto(css/pulse-animation): add 'alternate' and edit keyframes

Added Rust category and a snippet

[Snippet] [Fix] Added a bash snippet (technoph1le#219)

* removed bash icon

* fix comments of a script

* added kill_prev snippet

* followed guidelines

Remove language tag in guidelines

math - remap function

math - remap function to most languages

remap to linearMapping, args renamed

fix all mistakes,typos

added array manipulation snippets

removed unnecessary snippets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants