🐛 fix decode: properly account for strictNullHandling when `allowEm…

…ptyLists` (#21)
techouse · Jul 16, 2024 · d565c16 · d565c16
1 parent 887af0e
commit d565c16
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 1 deletion.
diff --git a/lib/src/extensions/decode.dart b/lib/src/extensions/decode.dart
@@ -105,7 +105,8 @@ extension _$Decode on QS {
       final String root = chain[i];
 
       if (root == '[]' && options.parseLists) {
-        obj = options.allowEmptyLists && leaf == ''
+        obj = options.allowEmptyLists &&
+                (leaf == '' || (options.strictNullHandling && leaf == null))
             ? List<dynamic>.empty(growable: true)
             : [if (leaf is Iterable) ...leaf else leaf];
       } else {

diff --git a/test/unit/decode_test.dart b/test/unit/decode_test.dart
@@ -260,6 +260,22 @@ void main() {
       );
     });
 
+    test(
+      'allowEmptyLists + strictNullHandling',
+      () {
+        expect(
+          QS.decode(
+            'testEmptyList[]',
+            const DecodeOptions(
+              strictNullHandling: true,
+              allowEmptyLists: true,
+            ),
+          ),
+          equals({'testEmptyList': []}),
+        );
+      },
+    );
+
     test('parses a single nested string', () {
       expect(
         QS.decode('a[b]=c'),

diff --git a/test/unit/encode_test.dart b/test/unit/encode_test.dart
@@ -457,6 +457,22 @@ void main() {
       },
     );
 
+    test(
+      'allowEmptyLists + strictNullHandling',
+      () {
+        expect(
+          QS.encode(
+            {'testEmptyList': []},
+            const EncodeOptions(
+              strictNullHandling: true,
+              allowEmptyLists: true,
+            ),
+          ),
+          equals('testEmptyList[]'),
+        );
+      },
+    );
+
     group('encodes a list value with one item vs multiple items', () {
       test(
         'non-list item',