524 - initail changes, added Alumni tab, reusable components #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sukritib13
requested review from
Anidion,
ParsaKargari,
Sahitiakella,
IsaiahA21 and
mortezafa
ParsaKargari
requested changes
Aug 31, 2024
…riti, Website Developer
Anidion
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Great work, this is looking good. Mainly code style feedback to look at.
Could you also add a transition for the background color?
Just background-color ease-in-out 0.2s would be enough
And on mobile, text should be centered vertically and the slider should have even spacing on both sides:
brian-ngyn
reviewed
Sep 10, 2024
brian-ngyn
reviewed
Sep 10, 2024
Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com>
brian-ngyn
reviewed
Sep 17, 2024
ParsaKargari
previously requested changes
Sep 18, 2024
Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com>
brian-ngyn
reviewed
Sep 24, 2024
brian-ngyn
reviewed
Sep 24, 2024
brian-ngyn
reviewed
Sep 24, 2024
brian-ngyn
reviewed
Sep 24, 2024
brian-ngyn
reviewed
Sep 24, 2024
|
Looks good, a few more comments + a rebase and should be good to go in |
Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com>
…janita-and-sajwal
brian-ngyn
reviewed
Sep 25, 2024
Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com>
…janita-and-sajwal
brian-ngyn
approved these changes
Sep 25, 2024
Sukritib13
dismissed
ParsaKargari’s stale review
Approvals received from other members
IsaiahA21
pushed a commit
that referenced
this pull request
Nov 14, 2024
* 524 - initail changes, added Alumni tab, reusable components * 524-Adding back Slider to UI, addressing comments. Signed-off-by: Sukriti, Website Developer * Addressing comments - creating helper functions, fixing styles Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * addressing comments - using var for bg color, using type for readability Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using types and correcting case Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using memoization Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> --------- Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> Co-authored-by: brian nguyen <brian.nguy1en@gmail.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com>
IsaiahA21
pushed a commit
that referenced
this pull request
Nov 14, 2024
* 524 - initail changes, added Alumni tab, reusable components * 524-Adding back Slider to UI, addressing comments. Signed-off-by: Sukriti, Website Developer * Addressing comments - creating helper functions, fixing styles Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * addressing comments - using var for bg color, using type for readability Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using types and correcting case Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using memoization Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> --------- Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> Co-authored-by: brian nguyen <brian.nguy1en@gmail.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com>
IsaiahA21
pushed a commit
that referenced
this pull request
Nov 14, 2024
* 524 - initail changes, added Alumni tab, reusable components * 524-Adding back Slider to UI, addressing comments. Signed-off-by: Sukriti, Website Developer * Addressing comments - creating helper functions, fixing styles Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * addressing comments - using var for bg color, using type for readability Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using types and correcting case Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using memoization Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> --------- Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> Co-authored-by: brian nguyen <brian.nguy1en@gmail.com>
IsaiahA21
added a commit
that referenced
this pull request
Nov 15, 2024
* setup PlayWright tests * Included more test cases * refactor: Updated documentation to include how to run Playwright tests * additonal updates to documentation * Added test coverage for navigation bar and project page * updated PlayWright config for a larger viewport size. And updated content-updates to include Playwright Recorder Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Tests that had to find image elements were based on style-components which will regenerated each time. \n Hence, added data-testid to PhotoGallery.tsx, Profile.tsx, FounderSection.styles.ts to images could be uniquely identified based on an id. Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * memorized the testdataId for the profile image. Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Inside useMemo, forgot to include return * Add data-testid to ApplyButton component for unique identification * Added an env variable for testing, and a globalSetup configuration file for running tests. * modify playwright.config.ts to take the value passed from the GitHub Actions * Add Playwright test workflow for Vercel deployment Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Fix Playwright installation command in Vercel workflow * Add workers to playwright test commands and uploaded the test-reports Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Update Playwright test report upload action to use version 4 because v2 was deprecated * Refactor Apply Now button in ProjectsPage.tsx and test.ts files * Refactor Playwright test workflow for Vercel deployment * revert homepage test back * Update content-updates.md Co-authored-by: Ben Schmidt <ben@schmidtfam.us> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * run playwright test after merging main * ran playwright test after merging main * chore: Update team member LinkedIn profile link (#519) Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * setup PlayWright tests Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Included more test cases Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * refactor: Updated documentation to include how to run Playwright tests Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * additonal updates to documentation Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Added test coverage for navigation bar and project page Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * updated PlayWright config for a larger viewport size. And updated content-updates to include Playwright Recorder Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Tests that had to find image elements were based on style-components which will regenerated each time. \n Hence, added data-testid to PhotoGallery.tsx, Profile.tsx, FounderSection.styles.ts to images could be uniquely identified based on an id. Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * memorized the testdataId for the profile image. Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Inside useMemo, forgot to include return Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Add data-testid to ApplyButton component for unique identification Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Added an env variable for testing, and a globalSetup configuration file for running tests. Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * modify playwright.config.ts to take the value passed from the GitHub Actions Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Add Playwright test workflow for Vercel deployment Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Fix Playwright installation command in Vercel workflow Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Add workers to playwright test commands and uploaded the test-reports Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Update Playwright test report upload action to use version 4 because v2 was deprecated Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Refactor Apply Now button in ProjectsPage.tsx and test.ts files Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Refactor Playwright test workflow for Vercel deployment Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * revert homepage test back Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Updated sponsor package link (#538) Signed-off-by: s-akella04 <sakella@cestatech.com> Co-authored-by: s-akella04 <sakella@cestatech.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Open Project Member applicaions for 24-25 year (#539) Signed-off-by: brian-ngyn <brian.nguy1en@gmail.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * handling empty PM list (#533) * handling empty PM list * Update src/components/TeamSection/TeamInformation.ts Co-authored-by: Ben Schmidt <ben@schmidtfam.us> Signed-off-by: Morteza Faraji <111158753+mortezafa@users.noreply.github.com> --------- Signed-off-by: Morteza Faraji <111158753+mortezafa@users.noreply.github.com> Co-authored-by: Ben Schmidt <ben@schmidtfam.us> * Labib Co-VP Finance (#542) Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * updating link to executive application (#544) Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * 524 - initail changes, added Alumni tab, reusable components (#536) * 524 - initail changes, added Alumni tab, reusable components * 524-Adding back Slider to UI, addressing comments. Signed-off-by: Sukriti, Website Developer * Addressing comments - creating helper functions, fixing styles Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * addressing comments - using var for bg color, using type for readability Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using types and correcting case Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using memoization Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> --------- Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> Co-authored-by: brian nguyen <brian.nguy1en@gmail.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * 2024-2025 PMs (#546) Signed-off-by: s-akella04 <sakella@cestatech.com> Co-authored-by: s-akella04 <sakella@cestatech.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * updating team execs 2024-2025 (#547) Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * run playwright test after merging main Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Update content-updates.md Co-authored-by: Ben Schmidt <ben@schmidtfam.us> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * ran playwright test after merging main Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * memorized the testdataId for the profile image. Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Inside useMemo, forgot to include return Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Add data-testid to ApplyButton component for unique identification Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Added an env variable for testing, and a globalSetup configuration file for running tests. Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * modify playwright.config.ts to take the value passed from the GitHub Actions Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Add Playwright test workflow for Vercel deployment Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Fix Playwright installation command in Vercel workflow Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Add workers to playwright test commands and uploaded the test-reports Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Update Playwright test report upload action to use version 4 because v2 was deprecated Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Refactor Apply Now button in ProjectsPage.tsx and test.ts files Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Refactor Playwright test workflow for Vercel deployment Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * revert homepage test back Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Updated sponsor package link (#538) Signed-off-by: s-akella04 <sakella@cestatech.com> Co-authored-by: s-akella04 <sakella@cestatech.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Open Project Member applicaions for 24-25 year (#539) Signed-off-by: brian-ngyn <brian.nguy1en@gmail.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * handling empty PM list (#533) * handling empty PM list * Update src/components/TeamSection/TeamInformation.ts Co-authored-by: Ben Schmidt <ben@schmidtfam.us> Signed-off-by: Morteza Faraji <111158753+mortezafa@users.noreply.github.com> --------- Signed-off-by: Morteza Faraji <111158753+mortezafa@users.noreply.github.com> Co-authored-by: Ben Schmidt <ben@schmidtfam.us> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Labib Co-VP Finance (#542) Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * updating link to executive application (#544) Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * 524 - initail changes, added Alumni tab, reusable components (#536) * 524 - initail changes, added Alumni tab, reusable components * 524-Adding back Slider to UI, addressing comments. Signed-off-by: Sukriti, Website Developer * Addressing comments - creating helper functions, fixing styles Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * addressing comments - using var for bg color, using type for readability Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using types and correcting case Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using memoization Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> --------- Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> Co-authored-by: brian nguyen <brian.nguy1en@gmail.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * 2024-2025 PMs (#546) Signed-off-by: s-akella04 <sakella@cestatech.com> Co-authored-by: s-akella04 <sakella@cestatech.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * updating team execs 2024-2025 (#547) Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * run playwright test after merging main Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Update content-updates.md Co-authored-by: Ben Schmidt <ben@schmidtfam.us> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * ran playwright test after merging main Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * setup PlayWright tests * refactor: Updated documentation to include how to run Playwright tests * additonal updates to documentation * Added test coverage for navigation bar and project page * updated PlayWright config for a larger viewport size. And updated content-updates to include Playwright Recorder Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Tests that had to find image elements were based on style-components which will regenerated each time. \n Hence, added data-testid to PhotoGallery.tsx, Profile.tsx, FounderSection.styles.ts to images could be uniquely identified based on an id. Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Refactor Apply Now button in ProjectsPage.tsx and test.ts files * Refactor Playwright test workflow for Vercel deployment * revert homepage test back Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Open Project Member applicaions for 24-25 year (#539) Signed-off-by: brian-ngyn <brian.nguy1en@gmail.com> Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * handling empty PM list (#533) * handling empty PM list * Update src/components/TeamSection/TeamInformation.ts Co-authored-by: Ben Schmidt <ben@schmidtfam.us> Signed-off-by: Morteza Faraji <111158753+mortezafa@users.noreply.github.com> --------- Signed-off-by: Morteza Faraji <111158753+mortezafa@users.noreply.github.com> Co-authored-by: Ben Schmidt <ben@schmidtfam.us> * Labib Co-VP Finance (#542) Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * updating link to executive application (#544) Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * 524 - initail changes, added Alumni tab, reusable components (#536) * 524 - initail changes, added Alumni tab, reusable components * 524-Adding back Slider to UI, addressing comments. Signed-off-by: Sukriti, Website Developer * Addressing comments - creating helper functions, fixing styles Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * addressing comments - using var for bg color, using type for readability Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using types and correcting case Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> * using memoization Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> --------- Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> Co-authored-by: brian nguyen <brian.nguy1en@gmail.com> * run playwright test after merging main * ran playwright test after merging main Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> * Nov7PlaywrightChanges * Everything working as expected --------- Signed-off-by: IsaiahA21 <76446914+IsaiahA21@users.noreply.github.com> Signed-off-by: s-akella04 <sakella@cestatech.com> Signed-off-by: brian-ngyn <brian.nguy1en@gmail.com> Signed-off-by: Morteza Faraji <111158753+mortezafa@users.noreply.github.com> Signed-off-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com> Co-authored-by: Ben Schmidt <ben@schmidtfam.us> Co-authored-by: Sahiti Akella <63627104+Sahitiakella@users.noreply.github.com> Co-authored-by: s-akella04 <sakella@cestatech.com> Co-authored-by: brian nguyen <brian.nguy1en@gmail.com> Co-authored-by: Morteza Faraji <111158753+mortezafa@users.noreply.github.com> Co-authored-by: Sukritib13 <113867416+Sukritib13@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes -