Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #48

Merged
merged 11 commits into from
Oct 18, 2021
Merged

Enhancements #48

merged 11 commits into from
Oct 18, 2021

Conversation

techthoughts2
Copy link
Owner

Pull Request

Description

Description of changes:

  • Adjusted error control and error return behavior - potential breaking change

    • Previous behavior: any error (API error, validation error [size requirements, extension verification, etc.] would return a Boolean value: $false)
      • This behavior wasn't especially helpful and did not provide a lot of insight into what went wrong
      • This behavior did not allow you to take any meaningful action if the API endpoint returned a certain error condition
    • New behavior:
      • Any validation error with throw for the failed validation
      • Any API error will return as a PSObject containing the API exception
        • Example 1:

          ok      error_code description
          --      ---------- -----------
          False          401 Unauthorized
        • Example 2:

          ok      error_code description                       parameters
          --      ---------- -----------                       ----------
          False          429 Too Many Requests: retry after 10 @{retry_after=10}
  • General code style adjustments throughout the code-base

  • Build/dev improvements

    • Bumped module versions to latest available
    • Updated Pester tests from Pester 4 to Pester 5
    • Updated CodeBuild to use latest version of PowerShell 7
    • Added new functionality to tasks.json
    • Updated infra tests to have API back off capability

License

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@techthoughts2 techthoughts2 added the enhancement New feature or request label Oct 18, 2021
@techthoughts2 techthoughts2 self-assigned this Oct 18, 2021
@techthoughts2 techthoughts2 merged commit f106001 into master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant