Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal changes to make it work with py3 with log and all #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DarioDaF
Copy link

Made the minimal amount of changes to make it work for python 3.8.0, should work fine in all python 3, can't test in python 2 (my initial idea was to strip out py2 support and make it a small tool, I just use it as main).

Fixed:

  • No log (NullHandler made it so it has a handler, having as effect to not use the default one, circumvented by actually setting also the streamhandler in main).
  • Debug crash (by simply calling tostr when objects are bytes in log statements)

Hope this gets tested in py2 and up in pip so I can start using it from the repo instead of shipping it (command line patch tools for windows are a rarity unfortunately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant