Fixes: missing functionality for svg <use> elements #653

ghost · 2023-10-09T08:22:58Z

Fixes: #652

Tested and confirmed working in PHP 7.4 and PHP 8.2

* README: tone down the warning about tc-lib-pdf Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de> * Update README.md Co-authored-by: William Desportes <williamdes@wdes.fr> --------- Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de> Co-authored-by: William Desportes <williamdes@wdes.fr>

* Fix of Deprecation warning with php 8.1 #614 * Update include/barcodes/qrcode.php Co-authored-by: William Desportes <williamdes@wdes.fr> --------- Co-authored-by: Robert Johnson Nallori <rnallori@evoketechnologies.com> Co-authored-by: johnson361 <johnson361@users.noreply.github.com> Co-authored-by: William Desportes <williamdes@wdes.fr>

* Update tcpdf_fonts.php Fixes "use of "self" in callables is deprecated" warning is arising from tcpdf_fonts.php when using PHP >= 8.2 * Update tcpdf_fonts.php for PHP 5.3-8.2 compatibility PHP 8.2 "use of "self" in callables is deprecated" yet some ways of fixing this breaks for PHP 5.3. This approach works, tested PHP 5.3.29 - 8.2.0 * Update tcpdf_fonts.php Spaces added back in before arguments * Update tcpdf_fonts.php using get_called_class() Maneuvers compatibility of callables inside array_map() between PHP 5.3 and 8.2 - tested. --------- Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

* Fix composite glyph output * Pad zeros before checksum calulation --------- Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

* fix for #583 * fix fix --------- Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

* Fix non-numeric value warning Fixes this warning on generating PDF: Warning: A non-numeric value encountered in /tcpdf/tcpdf.php on line 5473 * Better fix for non-numeric value warning Fixes this warning on generating PDF after calling `Text` with a non-numeric value for `$fstroke`: Warning: A non-numeric value encountered in /tcpdf/tcpdf.php on line 5470 * Update tcpdf.php Co-authored-by: William Desportes <williamdes@wdes.fr> --------- Co-authored-by: William Desportes <williamdes@wdes.fr> Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

This was already fixed in tc-lib-barcode.

* Fix return type annotation * BC with tools that do not support PHPStan annotations Co-authored-by: William Desportes <williamdes@wdes.fr> --------- Co-authored-by: William Desportes <williamdes@wdes.fr> Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

#598) * Typehints for get/setHeaderMargin are inconstent * Add typehints for header/footer margin properties --------- Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

* Bump actions/checkout and add PHP 8.3 * Update the composer json tests * Remove PHP 5.3 and 5.4 from the matrix * add permission entry Restrict GitHub actions access --------- Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

CLAassistant · 2023-10-09T08:23:05Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
16 out of 17 committers have signed the CLA.

✅ johnson361
✅ kosmro
✅ rubo77
✅ bruno-farias
✅ ren1244
✅ littlepackage
✅ theonlytruth
✅ remicollet
✅ d-salerno
✅ simonbuehler
✅ mvorisek
✅ nicolaasuni
✅ williamdes
✅ fisharebest
✅ plsnk
✅ survik1
❌ Nicole Krämer

Nicole Krämer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

tcpdf.php

williamdes · 2023-10-09T08:35:16Z

tcpdf.php

@@ -1641,6 +1641,20 @@ class TCPDF {
 	 */
 	protected $svgdefs = array();

+    /**


I am afraid this patch is not very minimal and so will have less changes being accepted into tcpdf

This library is part of the moodle core. We at TU Graz are relying on it to generate certificates, which among other contents contain logos of our partners (SVGs). Its crucial for us that they are correct on the pdf and currently this is not the case. Hence our contribution to this library.
Is there anything that can be done to increase chances? I will change up the contribution in any way necessary to provide this functionality. (:

First, thank you for contributing to the libraries you use !

Second, I am here as an advisor and try to monitor issues and pull-requests on my free time
Currently the library owner and maintainer remains mysterious in choices that are made. But it's mostly the rule of more the change is okay and small more it has chances to get on a release one day.

So from time to time I build an issue with a summary of PRs: #634
Maybe it helps, I never know, nobody knows
So it's a wait and see, but you need to get it slim and clean and right. Or it will probably get refused and you are back in a 6-8 months loop to get feedback on the new changes

This recent PR changed the library maintenance official statement, and that's a relief: #589

In summary, I think this patch will appear too large. Is there other ways to change less code ?

implement review changes Co-authored-by: William Desportes <williamdes@wdes.fr>

williamdes

Thank for making this patch !

BsAtHome · 2024-02-26T12:57:25Z

Hi,
There are still a few problems with this patch applied. The <use> element is more complicated than implemented by this patch. I have a problem file that shows the issue(s) (a cooked down test version from the original shown below).
There are three clipPath scenarios that I tested.

First is <use> in the <defs><clipPath> section with a forward reference to a path later on in the document. This scenario fails completely and no clipPath is applied.
Second is a copied version of the document's <path> in the <defs><clipPath> section, but it retained the original transformation attribute from the source. This scenario failed to apply the transformation.
Third is a working version, where the path is normalized.

The used svg (inkscape displays all three version correct):
<svg id="testUseClippath" width="100%" height="100%" viewBox="0 0 50 30" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<defs>
<clipPath id="usepath"><use xlink:href="#realpath" /></clipPath>


</defs>
<g>
<rect x="0.1" y="0.1" width="49.8" height="29.8" style="fill:none;stroke:#cc0;stroke-width:0.2" />
<g clip-path="url(#usepath)">
<rect x="0" y="0" width="50" height="30" style="fill:#222;stroke:none" />
<ellipse cx="25" cy="25" rx="15" ry="10" style="fill:#800f08;stroke:none" />
</g>
<path id="realpath" d="M 14,-1 C 10,1 6,9 0,9 C -6,9 -12,1 -14,-1 C -11,-2 -6,-9 0,-9 C 6,-9 11,-2 14,-1 Z" transform="translate(25,15)" style="fill:none;stroke:black;stroke-width:1" />
</g>
</svg>

nicolaasuni · 2024-04-20T17:22:33Z

Please try to resolve the conflicts.

remicollet and others added 23 commits September 6, 2023 08:51

Fix SPDX license ID (#591)

f7b000d

Applied fix found by BrainforgeUK in Issue #564 (#620)

70b63fa

Tested and confirmed working in PHP 7.4 and PHP 8.2

php 8+ edge cases fixes (#630)

de332db

Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

Fix composite glyph output (#581)

7e3fb6f

* Fix composite glyph output * Pad zeros before checksum calulation --------- Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

fix for #583 (#584)

9c7982d

* fix for #583 * fix fix --------- Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

Fixed problems with S25 barcode (#611)

26d2eed

This was already fixed in tc-lib-barcode.

Check fonts files with phpstan too (#575)

548c0f2

Typehints for getHeaderMargin() and setHeaderMargin() are inconsistent (

18d1b2b

#598) * Typehints for get/setHeaderMargin are inconstent * Add typehints for header/footer margin properties --------- Co-authored-by: Nicola Asuni <nicolaasuni@users.noreply.github.com>

Bump version

f209e39

Update copyright year

96985b9

Update the CHANGELOG for 6.6.3 (#643)

e3a8409

Bump version

31b9389

Fix corrupted file

3ca051c

Simplify test matrix

037283c

Remove duplicate settings

7689851

Adjust automation test settings

5fce932

support <use> element

b61cf06

williamdes reviewed Oct 9, 2023

View reviewed changes

tcpdf.php Outdated Show resolved Hide resolved

williamdes reviewed Oct 9, 2023

View reviewed changes

Update tcpdf.php

e3f0552

implement review changes Co-authored-by: William Desportes <williamdes@wdes.fr>

williamdes approved these changes Oct 9, 2023

View reviewed changes

nicolaasuni force-pushed the main branch from f9fd218 to 82fc97b Compare March 25, 2024 23:53

ghost closed this by deleting the head repository Oct 4, 2024

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes: missing functionality for svg <use> elements #653

Fixes: missing functionality for svg <use> elements #653

ghost commented Oct 9, 2023

CLAassistant commented Oct 9, 2023 •

edited

Loading

williamdes Oct 9, 2023

ghost Oct 9, 2023

williamdes Oct 9, 2023

williamdes left a comment

BsAtHome commented Feb 26, 2024

nicolaasuni commented Apr 20, 2024

Fixes: missing functionality for svg <use> elements #653

Fixes: missing functionality for svg <use> elements #653

Conversation

ghost commented Oct 9, 2023

CLAassistant commented Oct 9, 2023 • edited Loading

williamdes Oct 9, 2023

Choose a reason for hiding this comment

ghost Oct 9, 2023

Choose a reason for hiding this comment

williamdes Oct 9, 2023

Choose a reason for hiding this comment

williamdes left a comment

Choose a reason for hiding this comment

BsAtHome commented Feb 26, 2024

nicolaasuni commented Apr 20, 2024

CLAassistant commented Oct 9, 2023 •

edited

Loading