Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php8 #99

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Php8 #99

merged 7 commits into from
Nov 22, 2023

Conversation

nicolaasuni
Copy link
Member

This new main version requires PHP 8.0+
Static arrays were converted to constants.
Code has been cleaned up to pass phpstan 5 level.
Array types will be documented in the next PR in order to be able to increase the phpstan level to max.

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Attention: 329 lines in your changes are missing coverage. Please review.

Comparison is base (9ab1d9c) 0.00% compared to head (6771e36) 0.00%.

Files Patch % Lines
src/MetaInfo.php 0.00% 157 Missing ⚠️
src/Text.php 0.00% 64 Missing ⚠️
src/Cell.php 0.00% 55 Missing ⚠️
src/Tcpdf.php 0.00% 39 Missing ⚠️
src/ClassObjects.php 0.00% 8 Missing ⚠️
src/Base.php 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##              main     #99    +/-   ##
========================================
  Coverage     0.00%   0.00%            
+ Complexity     621     597    -24     
========================================
  Files            7       7            
  Lines         2753    2046   -707     
========================================
+ Misses        2753    2046   -707     
Flag Coverage Δ
php-5.6-ubuntu-latest ?
php-7.1-ubuntu-latest ?
php-7.2-ubuntu-latest ?
php-7.3-ubuntu-latest ?
php-7.4-ubuntu-latest ?
php-8.0-ubuntu-latest 0.00% <0.00%> (ø)
php-8.1-ubuntu-latest 0.00% <0.00%> (ø)
php-8.2-ubuntu-latest 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaasuni nicolaasuni merged commit 2fae563 into main Nov 22, 2023
3 checks passed
@nicolaasuni nicolaasuni deleted the php8 branch November 22, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants