Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set min_crossrefs to default to 2, not 0. #534

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

jneem
Copy link
Contributor

@jneem jneem commented Dec 28, 2019

In the original bibtex.web, the default value for min_crossrefs is 2, not 0. Thia matches that behaviour.

The bibtex distributed with texlive also defaults to min_crossrefs = 2 (and it also makes it configurable at run-time, with a CLI arg, which this patch doesn't do).

@codecov
Copy link

codecov bot commented Dec 28, 2019

Codecov Report

Merging #534 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #534      +/-   ##
=========================================
+ Coverage    45.5%   45.5%   +<.01%     
=========================================
  Files         137     137              
  Lines       59911   59912       +1     
=========================================
+ Hits        27263   27264       +1     
  Misses      32648   32648
Impacted Files Coverage Δ
tectonic/bibtex.c 44.06% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba372ed...2aa6ed0. Read the comment docs.

@pkgw
Copy link
Collaborator

pkgw commented Jan 3, 2020

Thanks! See #175, #475 for some related discussion.

If I had any actual time to work on this, I'd create a prototype new CLI client with a "multitool" style interface (e.g. tectonic init, tectonic build, tectonic show-cached-file) and a Tectonic.toml file defining the document in which one could set low-level parameters such as min_crossrefs.

@pkgw pkgw merged commit eb354de into tectonic-typesetting:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants