Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: attempt to gather code coverage info in the executable tests #638

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

pkgw
Copy link
Collaborator

@pkgw pkgw commented Sep 11, 2020

It turns out that our tests of the built tectonic executable weren't gathering code coverage information about the code paths exercised in those tests. I think that it's not so hard to hack in some support to gather that information, so let's give it a try.

CC @ralismark @Mrmaxmeier

xref: #636 assert-rs/assert_cmd#9

It turns out that our tests of the built `tectonic` executable weren't
gathering code coverage information about the code paths exercised in
those tests. I *think* that it's not so hard to hack in some support to
gather that information, so let's give it a try.
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #638 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
+ Coverage   46.25%   46.32%   +0.07%     
==========================================
  Files         139      131       -8     
  Lines       60448    59079    -1369     
==========================================
- Hits        27958    27367     -591     
+ Misses      32490    31712     -778     
Impacted Files Coverage Δ
tests/trip.rs
tests/util/mod.rs
tests/driver.rs
tests/formats.rs
tests/cached_itarbundle.rs
tests/bibtex.rs
tests/tex-outputs.rs
tectonic/dpx-pdfobj.c 46.13% <0.00%> (+0.12%) ⬆️
tectonic/dpx-t1_char.c 68.43% <0.00%> (+0.43%) ⬆️
tectonic/dpx-dpxcrypt.c 17.52% <0.00%> (+0.53%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64db8d7...74d2549. Read the comment docs.

@pkgw pkgw merged commit 280542d into tectonic-typesetting:master Sep 14, 2020
@pkgw pkgw deleted the executable-kcov branch September 14, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant