Make Shadowsocks-libev be the preferred option; Make wget check certificates; More shellcheck fixes
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceCodeNew
changed the title
Shadowsocks-libev be the preferred option; Make wget check certificates.Shadowsocks-libev be the preferred option; Make wget check certificates; More shellcheck fixes
我特意在整个 repo 范围内搜寻了一下 `--no-check-certificate` 或者其他可能的关键词，没有看到有人提 issue 说 wget 检查证书导致了错误，所以才加入这个参数来兼容。 那么我的意见是没有必要在一开始就加入这个参数，这降低了安全性，很多源代码都用到了 `wget` 拉下来，有必要通过验证证书确保拉下来的东西是未经篡改过的。 另外以我自己为例，我环境上 `wget` 还是一个 alias: `wget2 --progress=bar --secure-protocol=PFS --https-enforce=soft`，所以我打算一点一点地把脚本中的二进制改为通过绝对路径调用，避免 alias 和 脚本中参数冲突导致问题的可能性。
0. fix SC2068 1. fix SC2196 2. use `[[ … ]]` rather than `[ … ]` (refer: https://google.github.io/styleguide/shellguide.html#s6.3-tests)
|
实际跑过一遍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shadowsocks-libevbe the preferred option.我仔细检视过提供的 4 个安装选项，除了 libev 版本以外其他的都已经停止更新很久了。
Shadowsocks-Go可以考虑更换成go-shadowsocks2，但这估计免不了对相关部分的大改——而我并没有使用过go-shadowsocks2，所以只有看其他人在这方面进行贡献，然后我们可以再讨论究竟应该选择哪一个作为默认的安装选项。wgetcheck certificates.我特意在整个 repo 范围内搜寻了一下
--no-check-certificate或者其他可能的关键词，没有看到有人提 issue 说 wget 检查证书导致了错误，所以才加入这个参数来兼容。那么我的意见是没有必要在一开始就加入这个参数，这降低了安全性，很多源代码都用到了
wget拉下来，有必要通过验证证书确保拉下来的东西是未经篡改过的。另外以我自己为例，我环境上
wget还是一个 alias:wget2 --progress=bar --secure-protocol=PFS --https-enforce=soft，所以我打算一点一点地把脚本中的二进制改为通过绝对路径调用，避免 alias 和 脚本中参数冲突导致问题的可能性。