Mitigate T_ENCAPSED_AND_WHITESPACE bug #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 5.x will silently ignore the catch block)
1 similar comment
|
Thanks for the PR! |
|
I'll attempt to get a release out later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently ran into some trouble because of the slightly obscure and still unfixed T_ENCAPSED_AND_WHITESPACE bug in PHP. It has to do with string parts looking like variables.
First of all, the
include()should be protected by a try/catch block. This works in PHP 7 and PHP 5 will just ignore the catch block.Second, arrays and resources don’t need
serialize(), they can be enoded withvar_export()which returns native PHP code. Obviously, this will decode faster and is not prone to the forementioned bug.