Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error handling for domainToASCII #1608

Merged
merged 9 commits into from
Aug 7, 2024

Conversation

MichaelSun90
Copy link
Contributor

@MichaelSun90 MichaelSun90 commented Feb 28, 2024

switch from punyCode to node:url introduce a behavior difference: #1597 (comment)

This fix the behavior.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.11%. Comparing base (afd3b54) to head (950385a).

Files Patch % Lines
src/sender.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
+ Coverage   79.00%   79.11%   +0.10%     
==========================================
  Files          93       93              
  Lines        4878     4879       +1     
  Branches      937      937              
==========================================
+ Hits         3854     3860       +6     
+ Misses        718      711       -7     
- Partials      306      308       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelSun90
Copy link
Contributor Author

Hi @arthurschreiber, last time when we check this PR, you mentioned that description for this PR mentioned a test but it is missing from the changed files. I have went over the past commits, and I think we decided to remove the test since it seems the test is not needed. If you can give this PR a other look when you got time, see if we can merge this.

@MichaelSun90 MichaelSun90 changed the title chore: error handling for domainToASCII fix: error handling for domainToASCII Aug 7, 2024
@MichaelSun90 MichaelSun90 merged commit af21197 into master Aug 7, 2024
25 of 27 checks passed
Copy link

🎉 This PR is included in version 18.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant