Added range validation for BigInt data type. #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EGER in tests as these are not available in node 0.10.
@tvrprasad I think this change in behaviour is fine, as it's more of a bug fix than a "real change". We should include this with the next 1.x release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #490 opened by @beautifulcoder
@arthurschreiber This fixes what amounts to data corruption on insertions, which makes it important to fix soon. But this is also a breaking change in terms of behavior. Any thoughts on if should we wait for 2.0 to check this in or get this into the up coming 1.x release?