-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes made for table iteration #26
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
33993db
changes made for table iteration
rabelmervin b162ff2
changes made
rabelmervin e13d509
tested
rabelmervin ebe3616
Changes made
rabelmervin fa69117
formatted
rabelmervin c1c0b4d
changes
rabelmervin 5d572b2
changed
rabelmervin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -144,7 +144,19 @@ def test_version(): | |
assert result.exit_code == 0 | ||
|
||
from click.testing import CliRunner | ||
from paracelsus.cli import cli | ||
from paracelsus.cli import app | ||
|
||
from sqlalchemy import Column, Integer, String | ||
from sqlalchemy.ext.declarative import declarative_base | ||
|
||
Base = declarative_base() | ||
|
||
|
||
class Comments(Base): | ||
__tablename__ = 'comments' | ||
id = Column(Integer, primary_key=True) | ||
text = Column(String) | ||
|
||
|
||
|
||
|
||
|
@@ -159,13 +171,13 @@ def test_graph_with_inclusion_regex(package_path: Path): | |
"--python-dir", | ||
str(package_path), | ||
"--include-tables", | ||
"^com.*", | ||
"comments", | ||
], | ||
) | ||
assert result.exit_code == 0 | ||
assert "regular_table {" not in result.stdout | ||
assert "first_test {" in result.stdout | ||
assert "second{" not in result.stdout | ||
assert "comments {" in result.stdout | ||
assert "users {" not in result.stdout | ||
assert "post{" not in result.stdout | ||
|
||
|
||
def test_graph_with_exclusion_regex(package_path: Path): | ||
|
@@ -179,10 +191,10 @@ def test_graph_with_exclusion_regex(package_path: Path): | |
"--python-dir", | ||
str(package_path), | ||
"--exclude-tables", | ||
"pos.*", | ||
"^pos*", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm pretty sure this should be |
||
], | ||
) | ||
assert result.exit_code == 0 | ||
assert "regular_table {" in result.stdout | ||
assert "first {" not in result.stdout | ||
assert "second {" in result.stdout | ||
assert "comments {" in result.stdout | ||
assert "users {" in result.stdout | ||
assert "post {" not in result.stdout |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should remain
^com.*
, otherwise you aren't testing the regex.