Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes made for table iteration #26

Merged
merged 7 commits into from
Nov 21, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,19 @@ def test_version():
assert result.exit_code == 0

from click.testing import CliRunner
from paracelsus.cli import cli
from paracelsus.cli import app

from sqlalchemy import Column, Integer, String
from sqlalchemy.ext.declarative import declarative_base

Base = declarative_base()


class Comments(Base):
__tablename__ = 'comments'
id = Column(Integer, primary_key=True)
text = Column(String)




Expand All @@ -159,13 +171,13 @@ def test_graph_with_inclusion_regex(package_path: Path):
"--python-dir",
str(package_path),
"--include-tables",
"^com.*",
"comments",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain ^com.*, otherwise you aren't testing the regex.

],
)
assert result.exit_code == 0
assert "regular_table {" not in result.stdout
assert "first_test {" in result.stdout
assert "second{" not in result.stdout
assert "comments {" in result.stdout
assert "users {" not in result.stdout
assert "post{" not in result.stdout


def test_graph_with_exclusion_regex(package_path: Path):
Expand All @@ -179,10 +191,10 @@ def test_graph_with_exclusion_regex(package_path: Path):
"--python-dir",
str(package_path),
"--exclude-tables",
"pos.*",
"^pos*",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this should be ^pos.*

],
)
assert result.exit_code == 0
assert "regular_table {" in result.stdout
assert "first {" not in result.stdout
assert "second {" in result.stdout
assert "comments {" in result.stdout
assert "users {" in result.stdout
assert "post {" not in result.stdout