Regression: No longer possible to extend dictionary inside adjust block (+ sign is stripped)

[lukaszachy]

Expectation when running tmt -c dimension=value tests show for this test metadata is to have environment containing both 'FOO' and 'BAR' values.

However fmf-1.5.0+ makes tmt to get only the 'BAR' value.

Reproducer metadata:

test: echo
environment+:
  FOO: bar

adjust+:
  when: dimension == value
  environment+:
    BAR: baz

This seems to be caused by 'fmf' to report different 'raw' data:

fmf-1.4.0 shows environment+ inside adjust key

$ fmf_14 show
/repro
adjust: {'environment+': {'BAR': 'baz'}, 'when': 'dimension == value'}
environment: {'FOO': 'bar'}
test: echo

While recent (1.5.0 and 1.6.0) show environment: instead

$ fmf_16 show
/repro
adjust: {'environment': {'BAR': 'baz'}, 'when': 'dimension == value'}
environment: {'FOO': 'bar'}
test: echo

[lukaszachy]

bisect shows the regression happened in 759788f

[lukaszachy]

Decision: Revert #263, document that #190 is not possible in current fmf implementation.
To be released ASAP in 1.6.1

[lukaszachy]

Hm, if the reproducer is stored in 'main.fmf' and thus producing node named '/' then it contains 'adjust+' and 'environment+' keys. However if metadata cause named node (eg '/repro') by being in 'repro.fmf' file, or using '/repro:' in key, the node contains 'adjust' and 'environment'.

$ fmf show
/
adjust+: {'environment+': {'BAR': 'baz'}}
environment+: {'FOO': 'bar'}

$ mv main.fmf repro.fmf
$ fmf show
/repro
adjust: {'environment+': {'BAR': 'baz'}}
environment: {'FOO': 'bar'}