Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cpu.frequency hardware requirement for mrack #3297

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Oct 17, 2024

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@skycastlelily skycastlelily changed the title Cpu speed mrack Support cpu.speed hardware requirement for mrack Oct 17, 2024
@happz happz added area | hardware Implementation of hardware requirements plugin | mrack The beaker provision plugin ci | full test Pull request is ready for the full test execution labels Oct 17, 2024
@happz happz added this to the 1.38 milestone Oct 17, 2024
@happz
Copy link
Collaborator

happz commented Oct 22, 2024

Blocked on #3295

@happz happz added the status | blocked The merging of PR is blocked on some other issue label Oct 22, 2024
@thrix thrix modified the milestones: 1.38, 1.39 Oct 25, 2024
@skycastlelily skycastlelily changed the title Support cpu.speed hardware requirement for mrack Support cpu.frequency hardware requirement for mrack Oct 28, 2024
@skycastlelily skycastlelily removed the status | blocked The merging of PR is blocked on some other issue label Oct 28, 2024
spec/hardware/cpu.fmf Outdated Show resolved Hide resolved
@skycastlelily
Copy link
Collaborator Author

Rebased and updated,and it just occurred to me that I should update first in order to put the code addressing the comments in one commit, then rebased, will keep that in mind^^

spec/hardware/cpu.fmf Outdated Show resolved Hide resolved
tmt/hardware.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one small change if you could please :)

spec/hardware/cpu.fmf Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution plugin | mrack The beaker provision plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants