-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cpu.frequency
hardware requirement for mrack
#3297
Open
skycastlelily
wants to merge
4
commits into
main
Choose a base branch
from
cpu-speed-mrack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skycastlelily
requested review from
dav-pascual,
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
October 17, 2024 08:29
skycastlelily
added a commit
that referenced
this pull request
Oct 17, 2024
skycastlelily
force-pushed
the
cpu-speed-mrack
branch
from
October 17, 2024 08:29
14d9225
to
677d6c2
Compare
skycastlelily
changed the title
Cpu speed mrack
Support Oct 17, 2024
cpu.speed
hardware requirement for mrack
happz
added
area | hardware
Implementation of hardware requirements
plugin | mrack
The beaker provision plugin
ci | full test
Pull request is ready for the full test execution
labels
Oct 17, 2024
skycastlelily
added a commit
that referenced
this pull request
Oct 18, 2024
skycastlelily
force-pushed
the
cpu-speed-mrack
branch
from
October 18, 2024 00:34
677d6c2
to
39fc59d
Compare
Blocked on #3295 |
happz
added
the
status | blocked
The merging of PR is blocked on some other issue
label
Oct 22, 2024
skycastlelily
force-pushed
the
cpu-speed-mrack
branch
from
October 28, 2024 06:51
39fc59d
to
e405262
Compare
skycastlelily
changed the title
Support
Support Oct 28, 2024
cpu.speed
hardware requirement for mrack
cpu.frequency
hardware requirement for mrack
skycastlelily
removed
the
status | blocked
The merging of PR is blocked on some other issue
label
Oct 28, 2024
happz
reviewed
Nov 2, 2024
skycastlelily
force-pushed
the
cpu-speed-mrack
branch
from
November 3, 2024 14:26
e405262
to
8b1b80a
Compare
Rebased and updated,and it just occurred to me that I should update first in order to put the code addressing the comments in one commit, then rebased, will keep that in mind^^ |
skycastlelily
added a commit
that referenced
this pull request
Nov 4, 2024
skycastlelily
force-pushed
the
cpu-speed-mrack
branch
from
November 4, 2024 01:14
8b1b80a
to
0405eae
Compare
martinhoyer
reviewed
Nov 5, 2024
skycastlelily
added a commit
that referenced
this pull request
Nov 5, 2024
skycastlelily
force-pushed
the
cpu-speed-mrack
branch
from
November 5, 2024 15:13
0405eae
to
5227532
Compare
skycastlelily
added a commit
that referenced
this pull request
Nov 7, 2024
skycastlelily
force-pushed
the
cpu-speed-mrack
branch
from
November 7, 2024 09:08
5227532
to
e7056e3
Compare
martinhoyer
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just one small change if you could please :)
therazix
reviewed
Nov 7, 2024
skycastlelily
force-pushed
the
cpu-speed-mrack
branch
from
November 13, 2024 13:16
2a293b5
to
ea2d270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area | hardware
Implementation of hardware requirements
ci | full test
Pull request is ready for the full test execution
plugin | mrack
The beaker provision plugin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist