Fix several issues in /tests/discover/libraries
#3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psss
requested review from
lukaszachy,
happz,
thrix and
janhavlin
as code owners
psss
added
test coverage
martinhoyer
approved these changes
Nov 11, 2024
* Add the missing `rlPhaseEnd` which masked a failing assert * Simplify check for the `.git` suffix stripping * Modify pattern check for `dnf5` commands The `.git` suffix test case was exercising too much, including handling recommends covered by `/tests/prepare/recommend`. Also renamed to use dashes consistently.
psss
force-pushed
the
test-discover-libraries-failures
branch
from
254e65b
to
62cc781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rlPhaseEndwhich masked a failing assert.gitsuffix strippingdnf5commandsThe
.gitsuffix test case was exercising too much, including handling recommends covered by/tests/prepare/recommend. Also renamed to use dashes consistently.Pull Request Checklist