Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract tmt try and tmt init into their own tmt.cli modules #3394

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Extract tmt try and tmt init into their own tmt.cli modules #3394

merged 4 commits into from
Dec 10, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Dec 3, 2024

Ongoing process of splitting tmt.cli.

Pull Request Checklist

  • implement the feature

@happz happz added code | style Code style changes not affecting functionality code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Dec 3, 2024
@happz happz added this to the 1.40 milestone Dec 3, 2024
@happz happz added the ci | full test Pull request is ready for the full test execution label Dec 3, 2024
@happz
Copy link
Collaborator Author

happz commented Dec 3, 2024

/packit build

@psss
Copy link
Collaborator

psss commented Dec 6, 2024

/tests/unit/with-system-packages/basic is failing, looks like some further adjustments are needed:

AttributeError: module 'tmt.cli._root' has no attribute '_construct_trying_provision_options'

thrix
thrix approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just moving code around, I did not find any changes

@happz happz force-pushed the cli-split-try-and-init branch from 1dfb0a8 to 6271269 Compare December 10, 2024 13:51
@psss psss changed the title Extract tmt try and tmt init into their own tmt.cli modules Extract tmt try and tmt init into their own tmt.cli modules Dec 10, 2024
@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Dec 10, 2024
@psss psss force-pushed the cli-split-try-and-init branch from 1cf0c2c to 4b0eb32 Compare December 10, 2024 15:31
@psss
Copy link
Collaborator

psss commented Dec 10, 2024

One last change needed, fixed in 4b0eb32, ready for merge.

@psss
Copy link
Collaborator

psss commented Dec 10, 2024

The provision job failures are irrelevant, merging.

@psss psss merged commit 9e88909 into main Dec 10, 2024
19 of 20 checks passed
@psss psss deleted the cli-split-try-and-init branch December 10, 2024 20:21
@psss psss self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | style Code style changes not affecting functionality status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @psss @thrix @KwisatzHaderach