Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --workdir-root in the tmt clean images command #3426

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support --workdir-root in the tmt clean images command #3426

wants to merge 2 commits into from
+20 −8

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Dec 15, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@skycastlelily skycastlelily added the ci | full test Pull request is ready for the full test execution label Dec 15, 2024
@skycastlelily skycastlelily added this to the 1.41 milestone Dec 15, 2024
skycastlelily added a commit that referenced this pull request Dec 15, 2024
@skycastlelily
Support --workdir-root in the tmt clean images command (#3426)
e90ad16
@skycastlelily
Copy link
Collaborator Author

Block #2838 and the failing tests seem unrelated:)

skycastlelily added a commit that referenced this pull request Jan 7, 2025
@skycastlelily
Support --workdir-root in the tmt clean images command (#3426)
f5058f4
skycastlelily added a commit to skycastlelily/tmt that referenced this pull request Jan 10, 2025
@skycastlelily
Support --workdir-root in the tmt clean images command (teemtee#3426
d090cb8 
)
skycastlelily added a commit that referenced this pull request Jan 10, 2025
@skycastlelily
Support --workdir-root in the tmt clean images command (#3426)
c013f6b
@happz happz modified the milestones: 1.41, 1.42 Jan 13, 2025
@thrix
Copy link
Collaborator

thrix commented Jan 21, 2025

/packit retest-failed

@thrix thrix self-requested a review January 27, 2025 18:44
thrix
thrix approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thrix
Copy link
Collaborator

thrix commented Jan 28, 2025

@skycastlelily so this did not get enough review, but according to comments it would be good to cover this with tests, as seems it is not covered

@thrix thrix modified the milestones: 1.42, 1.43 Jan 28, 2025
@thrix thrix mentioned this pull request Jan 28, 2025
Open
8 tasks
optak
optak approved these changes Jan 28, 2025
View reviewed changes
Copy link

@optak optak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@optak optak optak approved these changes

@frantisekz frantisekz Awaiting requested review from frantisekz frantisekz is a code owner

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@happz happz Awaiting requested review from happz happz is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution
Projects
None yet
Milestone
1.43
Development

Successfully merging this pull request may close these issues.
4 participants
@skycastlelily @thrix @happz @optak