Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor verbosity options in tmt * show commands #3445

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Honor verbosity options in tmt * show commands #3445

merged 2 commits into from
Jan 23, 2025

Conversation

happz
Copy link
Collaborator

@happz happz commented Jan 6, 2025

The patch fixes it, but it's not perfect, e.g. verbosity inheritance may be incorrect in some cases.

Fixes #2364

Pull Request Checklist

  • implement the feature
  • extend the test coverage

@happz happz added bug Something isn't working code | cli Changes related to the command line interface labels Jan 6, 2025
@happz happz added this to the 1.41 milestone Jan 6, 2025
@happz happz added the ci | full test Pull request is ready for the full test execution label Jan 6, 2025
@happz happz modified the milestones: 1.41, 1.42 Jan 13, 2025
@psss psss mentioned this pull request Jan 14, 2025
Merged
3 tasks
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 21, 2025
@psss
Copy link
Collaborator

psss commented Jan 21, 2025

Seems that /tests/core/fmf-id is now failing with:

list index out of range
:: [ 14:20:30 ] :: [   FAIL   ] :: Command 'tmt plan -vvvv show /remote-plan-with-valid-ref' (Expected 0, got 2)

@psss psss changed the title tmt * show CLI commands were not honoring verbosity options Honor verbosity options in tmt * show commands Jan 21, 2025
@happz happz force-pushed the tmt-show-verbosity branch 2 times, most recently from 52024f4 to df8aab6 Compare January 21, 2025 20:56
@psss psss force-pushed the tmt-show-verbosity branch from df8aab6 to 2a7bb61 Compare January 22, 2025 11:23
happz added 2 commits January 22, 2025 16:09
@happz
tmt * show CLI commands were not honoring verbosity options
18779f8 
The patch fixes it, but it's not perfect, e.g. verbosity inheritance may
be incorrect in some cases.
@happz
squash: no fmf sources mean no clickable link
2b4c136
@happz happz force-pushed the tmt-show-verbosity branch from 2a7bb61 to 2b4c136 Compare January 22, 2025 15:09
@psss psss merged commit cc72da8 into main Jan 23, 2025
18 of 20 checks passed
@psss psss deleted the tmt-show-verbosity branch January 23, 2025 12:05
@psss psss self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszachy lukaszachy lukaszachy approved these changes

@skycastlelily skycastlelily skycastlelily approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees

@psss psss

Labels
bug Something isn't working ci | full test Pull request is ready for the full test execution code | cli Changes related to the command line interface status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.42
Development

Successfully merging this pull request may close these issues.

Verbose mode not working in tmt * show commands
4 participants
@happz @psss @lukaszachy @skycastlelily