Refactor and document test wrapper scripts #3448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
code | style
happz
requested review from
psss,
lukaszachy,
thrix,
janhavlin and
martinhoyer
as code owners
happz
force-pushed
the
refactor-test-wrapper-script
branch
from
7275e7a to
8e0405c
Compare
3 tasks
happz
added
the
status | blocking other work
happz
force-pushed
the
refactor-test-wrapper-script
branch
2 times, most recently
from
1ae59bc to
b205072
Compare
happz
force-pushed
the
refactor-test-wrapper-script
branch
from
b205072 to
d0f05e7
Compare
lukaszachy
requested changes
Feb 4, 2025
tmt/steps/execute/internal.py
Outdated
| # complicated shell script. To avoid issues with quotes and escaping | ||
| # things here and there, tmt saves the test script into the inner | ||
| # wrapper, and then the outer wrapper can work with just a single a | ||
| # single executable shell script. |
Yes, there are more than one, and the documentation comments were speaking just about one of them. So, giving them the names, adding more comments on why they exist, and changing the implementation to better reuse code when creating these wrappers.
happz
force-pushed
the
refactor-test-wrapper-script
branch
from
d0f05e7 to
d9cfa5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, there is more than one, and the documentation comments were speaking just about one of them. So, giving them the names, adding more comments on why they exist, and changing the implementation to better reuse code when creating these wrappers.
Pull Request Checklist