A bunch of minor code improvements #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LecrisUT
reviewed
Sep 19, 2024
| "tmt~=1.35", | ||
| "fastapi~=0.112", | ||
| "tmt~=1.36", | ||
| "fastapi~=0.115", |
There was a problem hiding this comment.
Not much worth locking dependencies, I think would be better to only >= if even necessary, github actions would pick up any incompatibilities, and probably there will be some packit packaging for the rest.
There was a problem hiding this comment.
hmm, probably not super important, but I'd keep it as is, unless you mean just specific packages. fwiw, they are not locked, well, only the major version is.
psss
approved these changes
Oct 8, 2024
psss
pushed a commit
that referenced
this pull request
Oct 8, 2024
* bump the dependencies to latest versions * fix the import of git_clone * no special reason for import alias * docstrings formatting and indentation problems * use f-strings instead * fix the order of imports * small improvements to readme * set execute permission to entrypoint.sh * small refactor of docstrings, unify quotation marks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.